Skip to content

Conversation

@bydawen
Copy link
Contributor

@bydawen bydawen commented Sep 9, 2025

Description

Complete the upgrade to Node 24 by removing the Node 20 CI check and going back to using .nvmrc as the source of truth for which version to use.

See the tracking issue for further information.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 9, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @bydawen!

This repository is currently maintained by @openedx/edx-infinity.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@bydawen bydawen self-assigned this Sep 9, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Sep 9, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Sep 10, 2025
@bydawen bydawen force-pushed the buhaienko/discussions/node24-upgrade-3 branch from 4a39216 to 1cc3c09 Compare September 11, 2025 11:44
@codecov
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.48%. Comparing base (899d1fa) to head (05708fc).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #811   +/-   ##
=======================================
  Coverage   94.48%   94.48%           
=======================================
  Files         167      167           
  Lines        3699     3699           
  Branches      999     1003    +4     
=======================================
  Hits         3495     3495           
  Misses        190      190           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cmltaWt0 cmltaWt0 mentioned this pull request Sep 8, 2025
3 tasks
@bydawen bydawen force-pushed the buhaienko/discussions/node24-upgrade-3 branch from 1cc3c09 to d6931aa Compare September 25, 2025 09:16
@github-project-automation github-project-automation bot moved this from Waiting on Author to Done in Contributions Sep 26, 2025
@arbrandes arbrandes merged commit 902490c into openedx:master Sep 26, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants