-
Notifications
You must be signed in to change notification settings - Fork 58
feat: support design tokens and paragon 23 #394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support design tokens and paragon 23 #394
Conversation
|
Thanks for the pull request, @dcoa! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
8612756 to
796345e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master-design-tokens #394 +/- ##
======================================================
Coverage 100.00% 100.00%
======================================================
Files 109 109
Lines 1087 1087
Branches 165 166 +1
======================================================
Hits 1087 1087 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Sandbox deployment successful 🚀 |
|
Sandbox deployment successful 🚀 |
025c449 to
f0c024a
Compare
|
Sandbox deployment successful 🚀 |
f0c024a to
f3da129
Compare
|
Sandbox deployment successful 🚀 |
f3da129 to
80b3d04
Compare
|
Sandbox deployment successful 🚀 |
80b3d04 to
d7faf10
Compare
d7faf10 to
b99e0d6
Compare
|
Sandbox deployment failed 💥 |
|
Sandbox deployment successful 🚀 |
brian-smith-tcril
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Beautiful! 🎉
e0a0e92
into
openedx:master-design-tokens
Warning
This PR should not be merge to
masterdirectly, it should point tomaster-design-tokensonce the branch has been created.Description
This PR updates frontend app ora grading to support CSS variables and the corresponding paragon design tokens.
Changes implemented
Important
This PR requires a compatible version with paragon 23 of dependencies because of that the following PRs need to be merged first:
How to test
Navigate in the sandbox