Skip to content

Commit 0c03c44

Browse files
authored
feat!: Upgrade eslint to v8
BREAKING CHANGE: Eslint was updated from v6 to v8. Since we have multiple apps depending on frontend-build, with this upgrade these apps could end up having linting issues.
1 parent ecdea39 commit 0c03c44

File tree

9 files changed

+2037
-2977
lines changed

9 files changed

+2037
-2977
lines changed

.eslintrc.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
const { createConfig } = require('./');
1+
const { createConfig } = require('.');
22

33
module.exports = createConfig('eslint', {
44
rules: {

bin/fedx-scripts.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ switch (commandName) {
5050
break;
5151
case 'eslint':
5252
ensureConfigOption(presets.eslint);
53-
require('eslint/bin/eslint');
5453
break;
5554
case 'jest':
5655
ensureConfigOption(presets.jest);

config/.eslintrc.js

Lines changed: 26 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,32 +1,35 @@
11
module.exports = {
2-
"extends": "@edx/eslint-config",
3-
"parser": "babel-eslint",
4-
"rules": {
5-
"import/no-extraneous-dependencies": [
6-
"error",
2+
extends: '@edx/eslint-config',
3+
parser: '@babel/eslint-parser',
4+
parserOptions: {
5+
requireConfigFile: false,
6+
},
7+
rules: {
8+
'import/no-extraneous-dependencies': [
9+
'error',
710
{
8-
"devDependencies": [
9-
"**/*.config.*",
10-
"**/*.test.*",
11-
"**/setupTest.js",
11+
devDependencies: [
12+
'**/*.config.*',
13+
'**/*.test.*',
14+
'**/setupTest.js',
1215
],
13-
}
16+
},
1417
],
15-
"import/no-unresolved": [
16-
"error",
18+
'import/no-unresolved': [
19+
'error',
1720
{
18-
"ignore": [
19-
"env.config"
20-
]
21-
}
21+
ignore: [
22+
'env.config',
23+
],
24+
},
2225
],
2326
// https://github.com/evcohen/eslint-plugin-jsx-a11y/issues/340#issuecomment-338424908
24-
"jsx-a11y/anchor-is-valid": [ "error", {
25-
"components": [ "Link" ],
26-
"specialLink": [ "to" ]
27+
'jsx-a11y/anchor-is-valid': ['error', {
28+
components: ['Link'],
29+
specialLink: ['to'],
2730
}],
2831
},
29-
"globals": {
30-
"newrelic": false
31-
}
32-
}
32+
globals: {
33+
newrelic: false,
34+
},
35+
};

config/webpack.dev-stage.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ const PostCssAutoprefixerPlugin = require('autoprefixer');
1010
const PostCssRTLCSS = require('postcss-rtlcss');
1111
const ReactRefreshWebpackPlugin = require('@pmmmwh/react-refresh-webpack-plugin');
1212

13-
const commonConfig = require('./webpack.common.config.js');
13+
const commonConfig = require('./webpack.common.config');
1414
const presets = require('../lib/presets');
1515
const resolvePrivateEnvConfig = require('../lib/resolvePrivateEnvConfig');
1616
const getLocalAliases = require('./getLocalAliases');

config/webpack.dev.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ const PostCssAutoprefixerPlugin = require('autoprefixer');
1010
const PostCssRTLCSS = require('postcss-rtlcss');
1111
const ReactRefreshWebpackPlugin = require('@pmmmwh/react-refresh-webpack-plugin');
1212

13-
const commonConfig = require('./webpack.common.config.js');
13+
const commonConfig = require('./webpack.common.config');
1414
const presets = require('../lib/presets');
1515
const resolvePrivateEnvConfig = require('../lib/resolvePrivateEnvConfig');
1616
const getLocalAliases = require('./getLocalAliases');

config/webpack.prod.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ const PostCssAutoprefixerPlugin = require('autoprefixer');
1515
const PostCssRTLCSS = require('postcss-rtlcss');
1616

1717
const HtmlWebpackNewRelicPlugin = require('../lib/plugins/html-webpack-new-relic-plugin');
18-
const commonConfig = require('./webpack.common.config.js');
18+
const commonConfig = require('./webpack.common.config');
1919
const presets = require('../lib/presets');
2020

2121
// Add process env vars. Currently used only for setting the PUBLIC_PATH.

example/.eslintrc.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
const config = require('../config/.eslintrc.js');
1+
const config = require('../config/.eslintrc');
22

33
module.exports = config;

0 commit comments

Comments
 (0)