-
Notifications
You must be signed in to change notification settings - Fork 2
chore: updated plugin slot configuration in ReadMe #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,7 +20,7 @@ frontend-plugin-notifications | |
Purpose | ||
======= | ||
|
||
This is the repository for storing Notification frontend plugin. Intended to be used with | ||
This is the repository for storing Notification Tray frontend plugin. Intended to be used with | ||
the `frontend-plugin-framework`_. | ||
|
||
.. _frontend-plugin-framework: https://github.com/openedx/frontend-plugin-framework | ||
|
@@ -31,53 +31,46 @@ Getting Started | |
Devstack Installation | ||
--------------------- | ||
|
||
These plugins are intended to be used with Header component. Make sure to follow the instructions on the MFE's | ||
This plugin is intended to be used with Header component. Make sure to follow the instructions on the MFE's | ||
repository README for getting set up in a devstack. | ||
|
||
Header in MFE should contain a plugin slot component to render the notifications tray. | ||
|
||
Local Development | ||
----------------- | ||
|
||
Clone this repository into your main workspace folder. | ||
|
||
Insert the following into the ``env.config.js`` file of MFE. If you haven't created one, create one | ||
in the root that includes the following:: | ||
|
||
Insert the following into the ``env.config.js`` file of MFE. If it doesn't exist, create one | ||
in the root and add the following configuration:: | ||
|
||
``` | ||
// Imports from frontend-plugin-framework | ||
import { DIRECT_PLUGIN, PLUGIN_OPERATIONS } from '@openedx/frontend-plugin-framework'; | ||
|
||
// Import plugin components from the npm package | ||
import { Notifications, useAppNotifications } from '@edx/frontend-plugin-notifications'; | ||
|
||
// Component to render notifications | ||
const NotificationsComponent = () => { | ||
const { notificationAppData } = useAppNotifications(); | ||
return notificationAppData?.showNotificationsTray | ||
? <Notifications notificationAppData={notificationAppData} /> | ||
: ''; | ||
}; | ||
import NotificationsTray from '@edx/frontend-plugin-notifications'; | ||
|
||
const config = { | ||
pluginSlots: { | ||
|
||
// Add configuration for each `notifications_slot`. This is the ID for the <PluginSlot> component | ||
notifications_slot: { | ||
// Add configuration for each notifications_slot. This is the ID for the <PluginSlot> component | ||
notifications_tray: { | ||
plugins: [ | ||
{ | ||
op: PLUGIN_OPERATIONS.Insert, | ||
widget: { | ||
id: 'notifications_tray', | ||
type: DIRECT_PLUGIN, | ||
RenderWidget: NotificationsComponent, | ||
RenderWidget: NotificationsTray, | ||
}, | ||
}, | ||
], | ||
}, | ||
}, | ||
}; | ||
|
||
export default config; | ||
|
||
``` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The code block closing uses markdown syntax (```) in an RST file. RST files should use proper RST formatting without explicit closing markers. Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||
|
||
To develop while using this plugin library, modify the ``module.config.js`` file in the root of the MFE you are | ||
developing in to reference the local version of the plugin.:: | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code block uses markdown syntax (```) in an RST file. RST files should use RST code block syntax with
::
directive instead.Copilot uses AI. Check for mistakes.