Conversation
Contributor
feanil
commented
Mar 24, 2026
feanil
commented
- feat: Run the backstage upgrade.
- fix: Restore GitHub sign-in requirement after frontend architecture upgrade
…pgrade The upgrade to Backstage 1.49.x migrated the frontend from the legacy `@backstage/app-defaults` architecture to the new declarative frontend system using `@backstage/frontend-defaults`. As part of that migration, App.tsx was reduced from ~109 lines to 7, and the explicit GitHub sign-in page configuration was dropped along with the old boilerplate. In the old system, the sign-in page was overridden via the `components` option of `createApp` (see the pre-upgrade App.tsx): https://github.com/openedx/openedx-backstage/blob/e66d00a/packages/app/src/App.tsx#L38-L50 components: { SignInPage: props => <SignInPage {...props} auto providers={[githubProvider]} /> } In the new declarative frontend system this override is done via a `SignInPageBlueprint` extension from `@backstage/plugin-app-react`: https://backstage.io/docs/frontend-system/architecture/extensions Without this, the new system fell back to attempting guest sign-in, which fails because guest is explicitly disabled in app-config.yaml (`guest: null`). The error was: "You cannot sign in as a guest, you must either enable the legacy guest token or configure the auth backend to support guest sign in." The fix creates a `signInPage` extension in `modules/nav/SignIn.tsx` using `SignInPageBlueprint` with `githubAuthApiRef` (now exported from `@backstage/frontend-plugin-api` rather than `@backstage/core-plugin-api`) requiring openedx org membership, and registers it in `navModule` alongside `SidebarContent`. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
e0d
approved these changes
Mar 25, 2026
Contributor
e0d
left a comment
e0d
left a comment
There was a problem hiding this comment.
A little hard to provide a useful review. Everything looks sane. I'm assuming that you have run it and it works.
Contributor
Author
|
Yea, I was able to run this locally with our staging credentials and everything comes up and works as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.