fix: <MenuItem> type wasn't accepting extra HTML props

[bradenmacdonald]

Description

When I pulled in the latest version of Paragon with the type improvements from #3831 there were some invalid type errors appearing in the Authoring MFE, like this:

src/taxonomy/TaxonomyListPage.tsx:130:11 - error TS2322: Type '{ children: string; key: string; className: string; iconAfter: () => Element | null; onClick: () => void; }' is not assignable to type 'IntrinsicAttributes & MenuItemProps'.
  Property 'onClick' does not exist on type 'IntrinsicAttributes & MenuItemProps'.

130 <MenuItem onClick={() => setSelectedOrgFilter(org)}
              ~~~~~~~

This fix updates the types to accept any valid HTML props, based on the as attribute.

Deploy Preview

https://deploy-preview-3955--paragon-openedx-v23.netlify.app/components/menu/ - Menu and MenuItem

https://deploy-preview-3955--paragon-openedx-v23.netlify.app/components/stack/ - Stack

Merge Checklist

• If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
• Does your change adhere to the documented style conventions?
• Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
• Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
• Were your changes tested in the example app?
• Is there adequate test coverage for your changes?
• Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please request an a11y review for the PR in the #wg-paragon Open edX Slack channel.

Post-merge Checklist

• Verify your changes were released to NPM at the expected version.
• If you'd like, share your contribution in #show-and-tell.
• 🎉 🙌 Celebrate! Thanks for your contribution.

[netlify]

✅ Deploy Preview for paragon-openedx-v23 ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	75ada93
🔍 Latest deploy log	https://app.netlify.com/projects/paragon-openedx-v23/deploys/69012d39e7d2c500083d3fa5
😎 Deploy Preview	https://deploy-preview-3955--paragon-openedx-v23.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[openedx-webhooks]

Thanks for the pull request, @bradenmacdonald!

This repository is currently maintained by @openedx/committers-paragon.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

---

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.37%. Comparing base (cce7beb) to head (75ada93).
⚠️ Report is 1 commits behind head on release-23.x.

Additional details and impacted files

@@              Coverage Diff              @@
##           release-23.x    #3955   +/-   ##
=============================================
  Coverage         94.37%   94.37%           
=============================================
  Files               242      242           
  Lines              4282     4282           
  Branches           1016     1016           
=============================================
  Hits               4041     4041           
  Misses              237      237           
  Partials              4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[brian-smith-tcril]

From what I can tell this should be a completely non-breaking change. If anything people will be able to "get away" with more props than before, so there shouldn't be any issues when renovate bumps this across the MFEs.

LGTM!

[bradenmacdonald]

Thanks @brian-smith-tcril :)

[openedx-semantic-release-bot]

🎉 This PR is included in version 23.15.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀