Skip to content

Conversation

@ewanharris
Copy link
Member

@ewanharris ewanharris commented Oct 23, 2025

Description

Missed this on the initial PR but added it to tag and release notes

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

Summary by CodeRabbit

  • Documentation
    • Updated changelog with contributor acknowledgments for the v0.9.2 release.

@Copilot Copilot AI review requested due to automatic review settings October 23, 2025 12:15
@ewanharris ewanharris requested a review from a team as a code owner October 23, 2025 12:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds an acknowledgment in the CHANGELOG.md to credit contributors for their work on the ListStores name filter feature, aligning with credits already added to tag and release notes.

  • Added contributor acknowledgment for @Oscmage and @varkart to the CHANGELOG entry

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 23, 2025

Walkthrough

A single line was added to the CHANGELOG.md file under the v0.9.2 "Added" section to acknowledge contributor names. No functional code, error handling, or control flow changes were made.

Changes

Cohort / File(s) Summary
Documentation Update
CHANGELOG.md
Added acknowledgment line thanking contributors in v0.9.2 "Added" section

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "docs: update liststores entry to include credit" is fully related to the main change in the changeset. The raw summary confirms that CHANGELOG.md is being updated with an acknowledgment line thanking contributors (@Oscmage and @varkart) under the v0.9.2 "Added" section, and the PR objectives explicitly state the goal is to add a missed credit entry to the liststores item. The title uses the "docs:" prefix appropriately to indicate a documentation-focused change and clearly specifies both what is being updated (liststores entry) and the primary change (including credit). The title is concise, specific, and meaningful enough that a teammate scanning the history would understand the core change.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch docs/add-changelog-credit

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7cb4c43 and b9e349c.

📒 Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Test and Build OpenFGA (17)
  • GitHub Check: Test and Build OpenFGA (11)
  • GitHub Check: Test and Build OpenFGA (21)
  • GitHub Check: Analyze (java)
🔇 Additional comments (1)
CHANGELOG.md (1)

14-14: LGTM!

The contributor credit is properly formatted, indented as a sub-bullet under the ListStores feature, and follows the established changelog style. This appropriately acknowledges the contributors' work on feature #237.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 36.33%. Comparing base (7cb4c43) to head (b9e349c).

❌ Your project status has failed because the head coverage (36.33%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #241   +/-   ##
=========================================
  Coverage     36.33%   36.33%           
  Complexity     1140     1140           
=========================================
  Files           187      187           
  Lines          7174     7174           
  Branches        822      822           
=========================================
  Hits           2607     2607           
  Misses         4462     4462           
  Partials        105      105           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ewanharris ewanharris added this pull request to the merge queue Oct 23, 2025
Merged via the queue into main with commit a46765a Oct 23, 2025
25 checks passed
@ewanharris ewanharris deleted the docs/add-changelog-credit branch October 23, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants