Skip to content
This repository was archived by the owner on Feb 5, 2022. It is now read-only.

Conversation

@Fdom92
Copy link
Contributor

@Fdom92 Fdom92 commented Dec 18, 2019

@Wholloran
Copy link
Contributor

Wholloran commented Jan 2, 2020

All:

  • "We want to put you to the test!" section needs its language and icon updated
  • "Are you prepared" text and icon needs to be updated (Notes this section is different under dev/design)
  • Tablet/desktop: add additional spacing between the paragraph titles and content (Forget normal interviews, we want to put you to the test, reputation is everything, are you prepared)
  • Update the slider titles for Design (the categories have changed)
    when the user's presses "apply" (under the sliders) the page changes but the user is not pushed to the top of the page, they should be
  • After the user navigates past the slider page, the animation at the top of the screen shows both the dev/design. per the marvel, it should only show the selected animation (dev or design)
  • swap the asset under "the ideal candidate can..." for the new one in the marvel (not this asset it dependent on dev/design
  • The "apply now" button under show us what you are made of should push the user to the application form

Desktop:

  • decrease the padding between the content and image for "the ideal candidate can" & "and can meet the following prerequisites". This was the text stretches further and isn't as stacked

Tablet:

  • The animation doesn't cover the full screen it's pushed to the left
  • "forget normal interviews" title and it's paragraph needs right-aligned per the marvel
  • the content for the opportunities landing page needs to be lower so it's not overlapping the gears/squares from the animation
  • when the user presses developer or Designer the background animation disappears (background is white) and then arrow animation is incorrect. (see screenshot)
    IMG_20200102_134905

Mobile:

  • "forget normal interviews" & "Reputation is everything" titles are not centered on mobile
    -The animation for when dev/design is selected needs to be centered and moved down on safari v12.4.1
  • "Show us what you're made of " should be stacked, the paragraph and the button under it should be center-aligned as well.
  • Add additional spacing between the apply now button and the dividing line
  • Center "ideal candidate can..." & "and can meet the following prerequisites"
  • move the assets from under "ideal candidate can..." to below the bullet points

Form:

  • Update Resume / Cv upload to match the marvel https://marvelapp.com/3f8d0id/screen/63248698
  • Remove the text above "Submit your application"
  • add place holder text for all fields
  • change github url to "link to your profile when under the design flow
  • add "*" to the end of the required field titles

@Fdom92
Copy link
Contributor Author

Fdom92 commented Jan 3, 2020

@Wholloran I updated the PR with lot of fixes for that feedback, but, all the assets or animation related I'm still waiting for them so I can not fix those ones yet

@Wholloran
Copy link
Contributor

sounds good. I'll do another pass to check the other fixes you implemented

@Wholloran Wholloran added QA Ready Fix is staged and ready for QA and removed QA Failed QA failed labels Jan 6, 2020
@Wholloran
Copy link
Contributor

Wholloran commented Jan 6, 2020

Updated List:

All:

  • Change the language under normal interview suck for the design side. that section should read: "At OpenForge, we believe that sometimes actions speak louder than words, so as part of your interview assignment, we’d like to challenge you to design 3 pages of an app of your choosing."
  • Have "Apply Now" scroll less (should show "submit your application" )
  • Still need assets swapped. if you still don't have the assets let me know tomorrow and I'll get the team to hand them off asap.

Desktop:

  • Add more white space above the hero image (before selecting Dev/design) it's getting cut off and the content isn't centered in it per the marvel

Tablet:

  • The animation doesn't cover the full screen it's pushed to the left
  • When the user presses developer or Designer the background animation disappears (background is white) and then arrow animation is incorrect. (see screenshot posted in the previous message)
  • "Show us what you made of" title and content should be left-aligned
  • "Ideal candidate" title & body should be left-aligned
  • "And can meet the following prerequisites:" title and body should be left-aligned
  • Form fields should be slimmer and centered per the marvel (title as well) (Desktop & tablet) https://marvelapp.com/57djie4/screen/62585458

Mobile:

  • The "Apply Now" button is not centered
  • The Design/Dev animation (after selecting the dev/design button) needs to be lowered. also on chrome, the animation needs to be centered

Form:

  • Change the design form to say "Portfolio" instead of profile & update placeholder text to say "your Portfolio"
  • add "*" to the end of Resume/CV

@Wholloran Wholloran added QA Failed QA failed and removed QA Ready Fix is staged and ready for QA labels Jan 6, 2020
@Fdom92
Copy link
Contributor Author

Fdom92 commented Jan 7, 2020

Added fix for:

  • Change the language under normal interview suck for the design side. that section should read: "At OpenForge, we believe that sometimes actions speak louder than words, so as part of your interview assignment, we’d like to challenge you to design 3 pages of an app of your choosing."
  • Have "Apply Now" scroll less (should show "submit your application" )
  • Add more white space above the hero image (before selecting Dev/design) it's getting cut off and the content isn't centered in it per the marvel
  • "Show us what you made of" title and content should be left-aligned
  • "Ideal candidate" title & body should be left-aligned
  • "And can meet the following prerequisites:" title and body should be left-aligned
  • The "Apply Now" button is not centered
  • Change the design form to say "Portfolio" instead of profile & update placeholder text to say "your Portfolio"
  • add "*" to the end of Resume/CV

@Wholloran Wholloran added QA Ready Fix is staged and ready for QA and removed QA Failed QA failed labels Jan 7, 2020
@Wholloran
Copy link
Contributor

Asset Corrections:

  • "We want to put you to the test" needs asset changed (this asset changes based on dev/design)
  • "Are you prepared" Needs asset changed (this asset changes based on dev/design)
  • "Show us what you are made of" is still showing both dev & design asset, should only show the one animation the page is for (dev/design) https://marvelapp.com/3f8d0id/screen/63248698
  • "The ideal candidate can" needs asset changed (this asset changes based on dev/design)

Mobile:

  • The Design/Dev animation (after selecting the dev/design button) needs to be lowered. also on chrome, the animation needs to be centered

Tablet:

  • The animation doesn't cover the full screen it's pushed to the left
  • When the user presses developer or Designer the background animation disappears (background is white) and then arrow animation is incorrect. (see screenshot posted in the previous message) (This is on the physical iPad in the office)
  • Form fields should be slimmer and centered per the marvel (title as well) (Desktop & tablet) https://marvelapp.com/57djie4/screen/62585458

@Wholloran Wholloran added QA Failed QA failed and removed QA Ready Fix is staged and ready for QA labels Jan 7, 2020
@Fdom92
Copy link
Contributor Author

Fdom92 commented Jan 8, 2020

Added fix for:

  • "We want to put you to the test" needs asset changed (this asset changes based on dev/design)
  • "Are you prepared" Needs asset changed (this asset changes based on dev/design)
  • "The ideal candidate can" needs asset changed (this asset changes based on dev/design)
  • The animation doesn't cover the full screen it's pushed to the left
  • Form fields should be slimmer and centered per the marvel

@Fdom92 Fdom92 added QA Ready Fix is staged and ready for QA and removed QA Failed QA failed labels Jan 8, 2020
@Fdom92
Copy link
Contributor Author

Fdom92 commented Jan 8, 2020

Ready for other round of QA.

  • When the user presses developer or Designer the background animation disappears (Can not reproduce)
  • Show us what you are made of" is still showing both dev & design asset (Need this animations)
  • The Design/Dev animation (after selecting the dev/design button) needs to be lowered (Might need new animation slowered)

@Wholloran
Copy link
Contributor

Desktop:

  • "Design Master" / "Code Master" icon needs to be smaller (Desktop) (this is on the first page, the second page this asset looks fine)

Mobile:

  • The Design/Dev animation (after selecting the dev/design button) needs to be lowered (Mobile) (I'm not worried about the speed of the animation. Just need the position corrected)

Form:

  • Remove the extra space between Portfolio / Github & "what makes you unique in the form

@Wholloran Wholloran removed the QA Ready Fix is staged and ready for QA label Jan 8, 2020
@Wholloran Wholloran added the QA Failed QA failed label Jan 8, 2020
@Wholloran
Copy link
Contributor

QA Passes

@Wholloran Wholloran added QA Passes and removed QA Failed QA failed labels Jan 8, 2020
@Wholloran Wholloran merged commit f829ef6 into develop Jan 8, 2020
@Fdom92 Fdom92 deleted the feat/opportunities branch January 10, 2020 08:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants