-
Notifications
You must be signed in to change notification settings - Fork 5
fix(about): active and hover styles #451
Conversation
src/pages/app-about/app-about.scss
Outdated
| } | ||
|
|
||
| &:not(:disabled):active { | ||
| background-color: #ff5d00; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use the global variable for this hexcode to keep it consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right, fixed
src/pages/app-about/app-about.scss
Outdated
|
|
||
| button { | ||
| &:hover { | ||
| background: #ff5d00; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use the global variable for this hexcode to keep it consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right, fixed
src/pages/app-about/app-about.scss
Outdated
|
|
||
| &:not(:disabled):active { | ||
| background-color: #ff5d00; | ||
| border-color: white; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a global variable for white, we should use that instead incase we ever need to adjust the shade of it at any point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right, fixed
src/pages/app-about/app-about.scss
Outdated
| button { | ||
| &:hover { | ||
| background: #ff5d00; | ||
| border-color: white; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a global variable for white, we should use that instead incase we ever need to adjust the shade of it at any point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right, fixed
|
@Wholloran @PaulPaulDevelops updated and fixed |
https://openforge.teamwork.com/#/tasks/17495250