Skip to content
This repository was archived by the owner on Feb 5, 2022. It is now read-only.

Conversation

@Fdom92
Copy link
Contributor

@Fdom92 Fdom92 commented Jan 9, 2020

}

&:not(:disabled):active {
background-color: #ff5d00;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use the global variable for this hexcode to keep it consistent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right, fixed


button {
&:hover {
background: #ff5d00;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use the global variable for this hexcode to keep it consistent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right, fixed


&:not(:disabled):active {
background-color: #ff5d00;
border-color: white;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a global variable for white, we should use that instead incase we ever need to adjust the shade of it at any point.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right, fixed

button {
&:hover {
background: #ff5d00;
border-color: white;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a global variable for white, we should use that instead incase we ever need to adjust the shade of it at any point.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right, fixed

@Fdom92
Copy link
Contributor Author

Fdom92 commented Jan 10, 2020

@Wholloran @PaulPaulDevelops updated and fixed

@Wholloran Wholloran merged commit 64e34be into develop Jan 10, 2020
@Fdom92 Fdom92 deleted the fix/about-button branch January 13, 2020 08:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants