-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: merge release v4.39.0 into master #459
Commits on Sep 30, 2020
-
chore(deps-dev): bump @types/node from 14.0.13 to 14.11.2 (#374)
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 14.0.13 to 14.11.2. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 8878e6b - Browse repository at this point
Copy the full SHA 8878e6bView commit details -
fix(deps): bump twilio from 3.46.0 to 3.49.3 (#367)
Bumps [twilio](https://github.com/twilio/twilio-node) from 3.46.0 to 3.49.3. - [Release notes](https://github.com/twilio/twilio-node/releases) - [Changelog](https://github.com/twilio/twilio-node/blob/main/CHANGES.md) - [Commits](twilio/twilio-node@3.46.0...3.49.3) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 1a3c942 - Browse repository at this point
Copy the full SHA 1a3c942View commit details -
chore(deps-dev): bump @types/uuid from 8.0.0 to 8.3.0 (#375)
* chore(deps-dev): bump @types/uuid from 8.0.0 to 8.3.0 Bumps [@types/uuid](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/uuid) from 8.0.0 to 8.3.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/uuid) Signed-off-by: dependabot[bot] <support@github.com> * chore: trigger travis Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kar Rui Lau <karrui.lau@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9c0cdcf - Browse repository at this point
Copy the full SHA 9c0cdcfView commit details -
Merge pull request #384 from opengovsg/release-v4.37.0
chore: merge release v4.37.0 back into develop
Configuration menu - View commit details
-
Copy full SHA for 3114683 - Browse repository at this point
Copy the full SHA 3114683View commit details -
fix: invalid key reference in retrieving form submissions (#385)
* fix: invalid key reference in retrieving form submissions
Configuration menu - View commit details
-
Copy full SHA for 98d5345 - Browse repository at this point
Copy the full SHA 98d5345View commit details -
Merge pull request #391 from opengovsg/release-v4.37.1
chore: merge Release v4.37.1 back into develop
Configuration menu - View commit details
-
Copy full SHA for e332b91 - Browse repository at this point
Copy the full SHA e332b91View commit details -
fix(deps): bump helmet from 4.1.0 to 4.1.1 (#390)
Bumps [helmet](https://github.com/helmetjs/helmet) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/helmetjs/helmet/releases) - [Changelog](https://github.com/helmetjs/helmet/blob/master/CHANGELOG.md) - [Commits](helmetjs/helmet@v4.1.0...v4.1.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for c605cfe - Browse repository at this point
Copy the full SHA c605cfeView commit details -
chore(deps-dev): bump @types/express from 4.17.6 to 4.17.8 (#392)
Bumps [@types/express](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/express) from 4.17.6 to 4.17.8. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/express) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 61b7d8e - Browse repository at this point
Copy the full SHA 61b7d8eView commit details -
fix(deps): bump aws-sdk from 2.734.0 to 2.763.0 (#393)
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.734.0 to 2.763.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-js@v2.734.0...v2.763.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for a74cbc2 - Browse repository at this point
Copy the full SHA a74cbc2View commit details
Commits on Oct 1, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 39e5aa7 - Browse repository at this point
Copy the full SHA 39e5aa7View commit details -
refactor: use validator's isEmail for validating email domains (#386)
* refactor: use validator's isEmail for validating email domains (prepend email domains with 'bob') * refactor: extract validation function into shared/util and apply validation function to directive too * fix: fix import path * fix: use relative path for import * docs: explain why we need to prepend "bob" to email domains during validation * refactor: add typing to createEmailFieldSchema instead of EmailFieldSchema * fix: use correct relative path to shared/util for require call
Configuration menu - View commit details
-
Copy full SHA for e59ea2d - Browse repository at this point
Copy the full SHA e59ea2dView commit details
Commits on Oct 2, 2020
-
chore(deps-dev): bump eslint from 7.9.0 to 7.10.0 (#401)
Bumps [eslint](https://github.com/eslint/eslint) from 7.9.0 to 7.10.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](eslint/eslint@v7.9.0...v7.10.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 551ea43 - Browse repository at this point
Copy the full SHA 551ea43View commit details -
fix(deps): bump multiparty from 4.2.1 to 4.2.2 (#406)
Bumps [multiparty](https://github.com/pillarjs/multiparty) from 4.2.1 to 4.2.2. - [Release notes](https://github.com/pillarjs/multiparty/releases) - [Changelog](https://github.com/pillarjs/multiparty/blob/master/HISTORY.md) - [Commits](pillarjs/multiparty@4.2.1...4.2.2) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 3d2ba0c - Browse repository at this point
Copy the full SHA 3d2ba0cView commit details
Commits on Oct 4, 2020
-
fix(deps): bump nodemailer from 6.4.11 to 6.4.12 (#399)
Bumps [nodemailer](https://github.com/nodemailer/nodemailer) from 6.4.11 to 6.4.12. - [Release notes](https://github.com/nodemailer/nodemailer/releases) - [Changelog](https://github.com/nodemailer/nodemailer/blob/master/CHANGELOG.md) - [Commits](nodemailer/nodemailer@v6.4.11...v6.4.12) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for cf6d4b3 - Browse repository at this point
Copy the full SHA cf6d4b3View commit details
Commits on Oct 5, 2020
-
Configuration menu - View commit details
-
Copy full SHA for c46c3b3 - Browse repository at this point
Copy the full SHA c46c3b3View commit details -
fix(deps): bump @sentry/browser from 5.22.3 to 5.24.2 (#407)
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 5.22.3 to 5.24.2. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md) - [Commits](getsentry/sentry-javascript@5.22.3...5.24.2) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 57862e9 - Browse repository at this point
Copy the full SHA 57862e9View commit details -
fix: transfer form toastr (#379)
* use toastr to show error and success messages * Add full stops Co-authored-by: Arshad Ali <arshadali@Arshads-MacBook-Pro.local>
Configuration menu - View commit details
-
Copy full SHA for 965f2a9 - Browse repository at this point
Copy the full SHA 965f2a9View commit details -
refactor: migrate SmsFactory to Typescript (#387)
* feat(FeatureManager): add stronger typings and export type from index * refactor: move sms related files into its own services/sms directory * tests(Sms): move sms_count specs into nested __tests__ directory * fix(sms): correct absolute import * feat(SmsFactory): migrate sms factory to Typescript * feat: add more info to SmsSendError for Twilio error codes and status * test(sms): migrate SmsService tests to Typescript * test(sms): add tests for sendAdminContactOtp fn * test(SmsFactory): add tests for sms feature disabled state * test(SmsFactory): add tests for sms feature enabled state * feat(MailService): sendNodeMail now resolves true on successful send * feat(VfnService): update sendOTPForField's return type to boolean * feat(FeatureManager): remove usage of non-null assertion * chore: trigger travis
Configuration menu - View commit details
-
Copy full SHA for df08618 - Browse repository at this point
Copy the full SHA df08618View commit details -
chore: add lint rule to prevent floating promises (#404)
* chore: add lint rule to prevent floating promises * fix: add await or void calls to floating promises * feat(FormModel): await pre-validate hook
Configuration menu - View commit details
-
Copy full SHA for 373761d - Browse repository at this point
Copy the full SHA 373761dView commit details -
feat: add trace to logs (#405)
* chore: install express-request-id * chore: update types * chore: use addRequestId() middleware * feat: add trace to logs * chore: add more traces * chore: include trace in loggingMiddleware
Configuration menu - View commit details
-
Copy full SHA for 306800f - Browse repository at this point
Copy the full SHA 306800fView commit details -
chore: bump version to v4.38.0
Arshad Ali authored and Arshad Ali committedOct 5, 2020 Configuration menu - View commit details
-
Copy full SHA for e940ef9 - Browse repository at this point
Copy the full SHA e940ef9View commit details -
chore(deps-dev): bump axios-mock-adapter from 1.18.1 to 1.18.2 (#411)
Bumps [axios-mock-adapter](https://github.com/ctimmerm/axios-mock-adapter) from 1.18.1 to 1.18.2. - [Release notes](https://github.com/ctimmerm/axios-mock-adapter/releases) - [Changelog](https://github.com/ctimmerm/axios-mock-adapter/blob/master/CHANGELOG.md) - [Commits](ctimmerm/axios-mock-adapter@v1.18.1...v1.18.2) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 17d1db9 - Browse repository at this point
Copy the full SHA 17d1db9View commit details
Commits on Oct 6, 2020
-
feat: add analytics module to handle /analytics endpoints (#403)
* feat(AnalyticsRouter): move /analytics routes into own router * feat(AnalyticsService): add getUsersCount function * refactor(AnalyticsRouter): replace handler for /users endpoint * feat(AnalyticsService): add getSubmissionsCount * feat(AnalyticsCtl): add handler for /submissions endpoint * refactor(AnalyticsRouter): replace handler for /submissions endpoint * feat(FeatureManager): add stronger typings and export type from index * feat(SubmissionModel): add static method findFormsWithSubsAbove * feat(FormStatsModel): add static method aggregateFormCount * feat(AnalyticsService): add getFormCount methods stats/subs collection * feat(AnalyticsFty): add factory to generate getFormCount method * refactor(AnalyticsRouter): replace handler for /forms endpoint * refactor(Analytics): rename handler functions to be more concise * feat(FormStatsModel): add missing formId key * test(SubmissionModel): add tests for static findFormsWithSubsAbove fn * test(FormStatsModel): add tests for static aggregateFormCount fn * test(AnalyticsService): add tests for getFormCount* methods Also remove form count related jasmine tests * test(AnalyticsService): add tests for getUserCount * test(AnalyticsService): add tests for getSubmissionCount * test(CoreCtl): remove tests for functions already refactored away * test(AnalyticsFty): add tests * test(AnalyticsCtl): add tests * fix(AnalyticsService): correct logged meta action names * test(AnalyticsCtl): tighten res.status call checks * feat: add private JSDoc key to factory invoked methods
Configuration menu - View commit details
-
Copy full SHA for f7dfa49 - Browse repository at this point
Copy the full SHA f7dfa49View commit details -
chore: use comments for PR template guiding questions (#420)
this allows us to not have to manually delete lines for a cleaner PR, and just insert wherever possible
Configuration menu - View commit details
-
Copy full SHA for ff7466e - Browse repository at this point
Copy the full SHA ff7466eView commit details -
chore(deps-dev): remove eslint-plugin-html (#402)
* chore(deps-dev): bump eslint-plugin-html from 6.0.2 to 6.1.0 Bumps [eslint-plugin-html](https://github.com/BenoitZugmeyer/eslint-plugin-html) from 6.0.2 to 6.1.0. - [Release notes](https://github.com/BenoitZugmeyer/eslint-plugin-html/releases) - [Changelog](https://github.com/BenoitZugmeyer/eslint-plugin-html/blob/master/CHANGELOG.md) - [Commits](BenoitZugmeyer/eslint-plugin-html@v6.0.2...v6.1.0) Signed-off-by: dependabot[bot] <support@github.com> * chore(deps-dev): remove eslint-plugin-html * chore: trigger travis Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kar Rui Lau <karrui.lau@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for be70c4d - Browse repository at this point
Copy the full SHA be70c4dView commit details -
* Add scripts for cleaning keys * Parse emails into appropriate format using mongoose setters * Add test to verify coersion of email string * Account for ; in emails and use bulk write * Rename folders * Rename scripts files and add additional checks for form script * Add script to transform recipient emails * Remove compatibility code that is no longer needed * Rename function to match purpose better * Make transformation func more robust * Remove unnecessary trim * Improve comments * Fix bugs by specifying collection * Rename variables and lint * Remove replacement of ; and neaten up code * Split by spaces also * Print out forms with invalid emails * Split recipient emails by space too * Print out invalid submission docs * Account for recipient emails not existing in some documents * Run bulk writes 100k at a time * Enforce that form.emails is of length at least 1 * Reject form.emails with semi-colon * Remove recipient email script Co-authored-by: Arshad Ali <arshadali@Arshads-MacBook-Pro.local>
Configuration menu - View commit details
-
Copy full SHA for 1a3ea78 - Browse repository at this point
Copy the full SHA 1a3ea78View commit details -
refactor: migrate CaptchaFactory to Typescript (#397)
* feat(FeatureManager): add stronger typings and export type from index * feat: migrate captcha factory to Typescript * feat(FeatureManager): remove accomplished TODO comment * fix(SmsFactory): add additional prop check in feature * test(SmsFty): update mocked feature typing
Configuration menu - View commit details
-
Copy full SHA for 979548e - Browse repository at this point
Copy the full SHA 979548eView commit details
Commits on Oct 7, 2020
-
Arshad Ali authored and Arshad Ali committed
Oct 7, 2020 Configuration menu - View commit details
-
Copy full SHA for 118257c - Browse repository at this point
Copy the full SHA 118257cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f4a771f - Browse repository at this point
Copy the full SHA f4a771fView commit details -
Configuration menu - View commit details
-
Copy full SHA for acc72d5 - Browse repository at this point
Copy the full SHA acc72d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for bfa3dfa - Browse repository at this point
Copy the full SHA bfa3dfaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c3248b - Browse repository at this point
Copy the full SHA 9c3248bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d07b159 - Browse repository at this point
Copy the full SHA d07b159View commit details -
Configuration menu - View commit details
-
Copy full SHA for f866ff6 - Browse repository at this point
Copy the full SHA f866ff6View commit details -
Configuration menu - View commit details
-
Copy full SHA for f780194 - Browse repository at this point
Copy the full SHA f780194View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7fa3034 - Browse repository at this point
Copy the full SHA 7fa3034View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2aa9e24 - Browse repository at this point
Copy the full SHA 2aa9e24View commit details -
feat: soft-launch rate-limiting of API endpoints (#389)
* feat: install express-rate-limit * feat: install types for express-rate-limit * feat: apply rate-limiting with test threshold * feat: log IP address * feat: increase rate limit to 600 * refactor: convert rate limit fn to util * refactor: remove old rate limits * feat: apply rate limit on submissions * feat: limit rate of sendotp endpoint * refactor: change rate limits to env vars * docs: add documentation for new env vars * test: add tests for limit-rate util
Configuration menu - View commit details
-
Copy full SHA for 0ade895 - Browse repository at this point
Copy the full SHA 0ade895View commit details
Commits on Oct 8, 2020
-
Merge pull request #430 from opengovsg/release-v4.38.1
chore: merge release v4.38.1 into develop
Configuration menu - View commit details
-
Copy full SHA for 9d85846 - Browse repository at this point
Copy the full SHA 9d85846View commit details -
Merge pull request #426 from opengovsg/refactor/res-json-2
* /billing * preview feedback * public feedback * SPCP redirect * signout * GET /user * celebrate
Configuration menu - View commit details
-
Copy full SHA for 5edb9af - Browse repository at this point
Copy the full SHA 5edb9afView commit details -
fix(deps): bump angular-cookies from 1.8.0 to 1.8.1 (#419)
Bumps [angular-cookies](https://github.com/angular/angular.js) from 1.8.0 to 1.8.1. - [Release notes](https://github.com/angular/angular.js/releases) - [Changelog](https://github.com/angular/angular.js/blob/master/CHANGELOG.md) - [Commits](angular/angular.js@v1.8.0...v1.8.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 1010fae - Browse repository at this point
Copy the full SHA 1010faeView commit details -
Configuration menu - View commit details
-
Copy full SHA for d8bbdd1 - Browse repository at this point
Copy the full SHA d8bbdd1View commit details -
Configuration menu - View commit details
-
Copy full SHA for d7269d5 - Browse repository at this point
Copy the full SHA d7269d5View commit details