chore: merge release v4.39.0 into master #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 14.0.13 to 14.11.2. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [twilio](https://github.com/twilio/twilio-node) from 3.46.0 to 3.49.3. - [Release notes](https://github.com/twilio/twilio-node/releases) - [Changelog](https://github.com/twilio/twilio-node/blob/main/CHANGES.md) - [Commits](twilio/twilio-node@3.46.0...3.49.3) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore(deps-dev): bump @types/uuid from 8.0.0 to 8.3.0 Bumps [@types/uuid](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/uuid) from 8.0.0 to 8.3.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/uuid) Signed-off-by: dependabot[bot] <support@github.com> * chore: trigger travis Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kar Rui Lau <karrui.lau@gmail.com>
chore: merge release v4.37.0 back into develop
* fix: invalid key reference in retrieving form submissions
chore: merge Release v4.37.1 back into develop
Bumps [helmet](https://github.com/helmetjs/helmet) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/helmetjs/helmet/releases) - [Changelog](https://github.com/helmetjs/helmet/blob/master/CHANGELOG.md) - [Commits](helmetjs/helmet@v4.1.0...v4.1.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@types/express](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/express) from 4.17.6 to 4.17.8. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/express) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.734.0 to 2.763.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-js@v2.734.0...v2.763.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* refactor: use validator's isEmail for validating email domains (prepend email domains with 'bob') * refactor: extract validation function into shared/util and apply validation function to directive too * fix: fix import path * fix: use relative path for import * docs: explain why we need to prepend "bob" to email domains during validation * refactor: add typing to createEmailFieldSchema instead of EmailFieldSchema * fix: use correct relative path to shared/util for require call
Bumps [eslint](https://github.com/eslint/eslint) from 7.9.0 to 7.10.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](eslint/eslint@v7.9.0...v7.10.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [multiparty](https://github.com/pillarjs/multiparty) from 4.2.1 to 4.2.2. - [Release notes](https://github.com/pillarjs/multiparty/releases) - [Changelog](https://github.com/pillarjs/multiparty/blob/master/HISTORY.md) - [Commits](pillarjs/multiparty@4.2.1...4.2.2) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [nodemailer](https://github.com/nodemailer/nodemailer) from 6.4.11 to 6.4.12. - [Release notes](https://github.com/nodemailer/nodemailer/releases) - [Changelog](https://github.com/nodemailer/nodemailer/blob/master/CHANGELOG.md) - [Commits](nodemailer/nodemailer@v6.4.11...v6.4.12) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 5.22.3 to 5.24.2. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md) - [Commits](getsentry/sentry-javascript@5.22.3...5.24.2) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* use toastr to show error and success messages * Add full stops Co-authored-by: Arshad Ali <arshadali@Arshads-MacBook-Pro.local>
* feat(FeatureManager): add stronger typings and export type from index * refactor: move sms related files into its own services/sms directory * tests(Sms): move sms_count specs into nested __tests__ directory * fix(sms): correct absolute import * feat(SmsFactory): migrate sms factory to Typescript * feat: add more info to SmsSendError for Twilio error codes and status * test(sms): migrate SmsService tests to Typescript * test(sms): add tests for sendAdminContactOtp fn * test(SmsFactory): add tests for sms feature disabled state * test(SmsFactory): add tests for sms feature enabled state * feat(MailService): sendNodeMail now resolves true on successful send * feat(VfnService): update sendOTPForField's return type to boolean * feat(FeatureManager): remove usage of non-null assertion * chore: trigger travis
* chore: add lint rule to prevent floating promises * fix: add await or void calls to floating promises * feat(FormModel): await pre-validate hook
* chore: install express-request-id * chore: update types * chore: use addRequestId() middleware * feat: add trace to logs * chore: add more traces * chore: include trace in loggingMiddleware
Bumps [axios-mock-adapter](https://github.com/ctimmerm/axios-mock-adapter) from 1.18.1 to 1.18.2. - [Release notes](https://github.com/ctimmerm/axios-mock-adapter/releases) - [Changelog](https://github.com/ctimmerm/axios-mock-adapter/blob/master/CHANGELOG.md) - [Commits](ctimmerm/axios-mock-adapter@v1.18.1...v1.18.2) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat(AnalyticsRouter): move /analytics routes into own router * feat(AnalyticsService): add getUsersCount function * refactor(AnalyticsRouter): replace handler for /users endpoint * feat(AnalyticsService): add getSubmissionsCount * feat(AnalyticsCtl): add handler for /submissions endpoint * refactor(AnalyticsRouter): replace handler for /submissions endpoint * feat(FeatureManager): add stronger typings and export type from index * feat(SubmissionModel): add static method findFormsWithSubsAbove * feat(FormStatsModel): add static method aggregateFormCount * feat(AnalyticsService): add getFormCount methods stats/subs collection * feat(AnalyticsFty): add factory to generate getFormCount method * refactor(AnalyticsRouter): replace handler for /forms endpoint * refactor(Analytics): rename handler functions to be more concise * feat(FormStatsModel): add missing formId key * test(SubmissionModel): add tests for static findFormsWithSubsAbove fn * test(FormStatsModel): add tests for static aggregateFormCount fn * test(AnalyticsService): add tests for getFormCount* methods Also remove form count related jasmine tests * test(AnalyticsService): add tests for getUserCount * test(AnalyticsService): add tests for getSubmissionCount * test(CoreCtl): remove tests for functions already refactored away * test(AnalyticsFty): add tests * test(AnalyticsCtl): add tests * fix(AnalyticsService): correct logged meta action names * test(AnalyticsCtl): tighten res.status call checks * feat: add private JSDoc key to factory invoked methods
this allows us to not have to manually delete lines for a cleaner PR, and just insert wherever possible
* chore(deps-dev): bump eslint-plugin-html from 6.0.2 to 6.1.0 Bumps [eslint-plugin-html](https://github.com/BenoitZugmeyer/eslint-plugin-html) from 6.0.2 to 6.1.0. - [Release notes](https://github.com/BenoitZugmeyer/eslint-plugin-html/releases) - [Changelog](https://github.com/BenoitZugmeyer/eslint-plugin-html/blob/master/CHANGELOG.md) - [Commits](BenoitZugmeyer/eslint-plugin-html@v6.0.2...v6.1.0) Signed-off-by: dependabot[bot] <support@github.com> * chore(deps-dev): remove eslint-plugin-html * chore: trigger travis Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kar Rui Lau <karrui.lau@gmail.com>
* Add scripts for cleaning keys * Parse emails into appropriate format using mongoose setters * Add test to verify coersion of email string * Account for ; in emails and use bulk write * Rename folders * Rename scripts files and add additional checks for form script * Add script to transform recipient emails * Remove compatibility code that is no longer needed * Rename function to match purpose better * Make transformation func more robust * Remove unnecessary trim * Improve comments * Fix bugs by specifying collection * Rename variables and lint * Remove replacement of ; and neaten up code * Split by spaces also * Print out forms with invalid emails * Split recipient emails by space too * Print out invalid submission docs * Account for recipient emails not existing in some documents * Run bulk writes 100k at a time * Enforce that form.emails is of length at least 1 * Reject form.emails with semi-colon * Remove recipient email script Co-authored-by: Arshad Ali <arshadali@Arshads-MacBook-Pro.local>
* feat(FeatureManager): add stronger typings and export type from index * feat: migrate captcha factory to Typescript * feat(FeatureManager): remove accomplished TODO comment * fix(SmsFactory): add additional prop check in feature * test(SmsFty): update mocked feature typing
* feat: install express-rate-limit * feat: install types for express-rate-limit * feat: apply rate-limiting with test threshold * feat: log IP address * feat: increase rate limit to 600 * refactor: convert rate limit fn to util * refactor: remove old rate limits * feat: apply rate limit on submissions * feat: limit rate of sendotp endpoint * refactor: change rate limits to env vars * docs: add documentation for new env vars * test: add tests for limit-rate util
chore: merge release v4.38.1 into develop
* /billing * preview feedback * public feedback * SPCP redirect * signout * GET /user * celebrate
Bumps [angular-cookies](https://github.com/angular/angular.js) from 1.8.0 to 1.8.1. - [Release notes](https://github.com/angular/angular.js/releases) - [Changelog](https://github.com/angular/angular.js/blob/master/CHANGELOG.md) - [Commits](angular/angular.js@v1.8.0...v1.8.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
mantariksh
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges v4.39.0 into master as a stable release.