Skip to content

chore(deps): patch 13 of 15 Dependabot alerts#47

Merged
NicolaasGrobler merged 2 commits into
mainfrom
chore/dependabot-security-fixes
May 15, 2026
Merged

chore(deps): patch 13 of 15 Dependabot alerts#47
NicolaasGrobler merged 2 commits into
mainfrom
chore/dependabot-security-fixes

Conversation

@NicolaasGrobler

@NicolaasGrobler NicolaasGrobler commented May 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

Closes 13 of 15 open Dependabot alerts. Two transitive alerts (glib 0.18.5, rand 0.7.3) are deferred — they're pinned by tauri 2.11.1 and need an upstream Tauri bump to GTK 0.20 bindings.

Fixes

# Severity Package Change
15 high quinn-proto Cargo.lock 0.11.13 → 0.11.14
13 medium astro website astro ^5 → ^6 (6.3.2)
14 low astro (same bump)
6 medium vite vitest ^2.1.9 → ^3.2.4 dedupes nested vite to 6.4.2
1 medium esbuild (same bump) dedupes esbuild to 0.25.12
2, 3, 4, 5, 7, 8, 9, 10 medium dompurify npm overrides forces monaco's nested dompurify to ^3.4.3

Won't fix in this PR

Code change beyond lockfiles

Astro 6 changed prerender chunk layout, breaking the relative-path readFileSync in website/src/lib/changelog.ts. Switched to a Vite ?raw import — bundled at build time, no runtime filesystem lookup, strictly more robust.

Test plan

  • npx tsc --noEmit clean
  • npm test — all 82 vitest tests pass on vitest 3
  • cargo check clean
  • cd website && npx astro build clean (22 pages built including /changelog)
  • CI green

Summary by CodeRabbit

  • Chores
    • Updated Vitest to v3.2.4 for development
    • Updated Astro to v6.0.0 and Astro MDX integration to v5.0.0

Review Change Stack

Fixes:
- #15 quinn-proto DoS (high): Cargo.lock 0.11.13 -> 0.11.14
- #13/#14 astro XSS + replay: astro ^5 -> ^6 (6.3.2), @astrojs/mdx ^4 -> ^5
- #6 vite path traversal, #1 esbuild dev server: vitest ^2.1.9 -> ^3.2.4
  dedupes nested vite to 6.4.2 and esbuild to 0.25.12
- #2-#5, #7-#10 dompurify (8 alerts): npm overrides force monaco's
  nested dompurify to ^3.4.3

Astro 6 changed prerender chunk layout, breaking the relative path
readFileSync in website/src/lib/changelog.ts. Switched to a Vite ?raw
import so the changelog is bundled at build time.

Won't-fix (transitive, pinned by tauri 2.11.1):
- #11 glib 0.18.5 unsoundness — needs tauri to bump gtk 0.18 -> 0.20
- #12 rand 0.7.3 unsoundness — pulled via tauri-utils -> kuchikiki ->
  phf_codegen; build-time only, custom-logger-triggered, non-exploitable

Verified: tsc --noEmit clean, 82 vitest tests pass, cargo check clean,
astro build clean.
@vercel

vercel Bot commented May 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
queryden Ready Ready Preview, Comment May 15, 2026 4:26am

@coderabbitai

coderabbitai Bot commented May 15, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fcb0bf26-3faa-4c97-857c-f572b3a3187e

📥 Commits

Reviewing files that changed from the base of the PR and between 6fd1da2 and a39289e.

⛔ Files ignored due to path filters (3)
  • package-lock.json is excluded by !**/package-lock.json
  • src-tauri/Cargo.lock is excluded by !**/*.lock
  • website/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (3)
  • package.json
  • website/package.json
  • website/src/lib/changelog.ts

📝 Walkthrough

Walkthrough

This PR upgrades Astro and related dependencies in the website package, refactors changelog loading to use Astro's raw import instead of Node filesystem APIs, and bumps vitest to version 3 in the root package dependencies.

Changes

Tooling and Dependency Updates

Layer / File(s) Summary
Website dependencies upgrade
website/package.json
Astro bumped from ^5.0.0 to ^6.0.0 and @astrojs/mdx bumped from ^4.3.14 to ^5.0.0 to support the new changelog loading approach.
Changelog loading via Astro raw import
website/src/lib/changelog.ts
Changelog now imports CHANGELOG.md directly using Astro's ?raw query parameter as CHANGELOG_RAW instead of reading from disk with Node fs/url/path, eliminating filesystem I/O at runtime.
Vitest development dependency upgrade
package.json
vitest upgraded from ^2.1.9 to ^3.2.4 in root package devDependencies.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

A rabbit hops through the dependencies with glee,
Astro raw imports flow swift and free,
vitest climbs higher, version three's here,
Changelog loads faster, without a filesystem tear, 🐰✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main objective of the PR: addressing 13 out of 15 Dependabot security alerts through dependency version updates.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/dependabot-security-fixes

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@NicolaasGrobler NicolaasGrobler merged commit 3ca16eb into main May 15, 2026
10 checks passed
@NicolaasGrobler NicolaasGrobler deleted the chore/dependabot-security-fixes branch May 15, 2026 04:28
NicolaasGrobler added a commit that referenced this pull request May 16, 2026
The v1.0.14 release commit shipped without entries for two app-relevant changes that landed before the tag:

- #56 — cold-start window-hidden-until-paint + Monaco lazy-load from MainContent (entry bundle ~4 MB -> 524 kB / 151 kB gzip).
- #47 — 13 of 15 open Dependabot alerts patched (quinn-proto, astro 5->6, vitest 2->3, dompurify override), with glib/rand deferred behind a Tauri bump.

Also bumped the release date from 2026-05-15 to 2026-05-16 to match the actual tag date.

Refs #47 #56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant