Swift 5 compatibility #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenji21
force-pushed
the
master
branch
3 times, most recently
from
659ab9e to
fa744f1
Compare
Drusy
requested changes
Mar 27, 2019
SwiftiumKit/Crypto.m
Outdated
| bzero(keyPtr, keySize+1); // fill with zeroes (for padding) | ||
|
|
||
| memcpy(keyPtr, key, keySize+1); | ||
| memcpy(keyPtr, key, MAX(keyLength, keySize)); |
There was a problem hiding this comment.
Some size refer to keySize+1 and some to MAX(keyLength, keySize), which one is the good one ?
There was a problem hiding this comment.
fixed up by rewriting history to remove this change
Drusy
approved these changes
Mar 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.