8293361: GHA: dump config.log in case of configure failure

[magicus]

If configure fails in GHA it is very hard to debug. Dumping the contents of config.log helps.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8293361: GHA: dump config.log in case of configure failure

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10165/head:pull/10165
$ git checkout pull/10165

Update a local copy of the PR:
$ git checkout pull/10165
$ git pull https://git.openjdk.org/jdk pull/10165/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10165

View PR using the GUI difftool:
$ git pr show -t 10165

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10165.diff

[bridgekeeper]

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@magicus The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (8f3eccad)

[shipilev]

Is it a large file? Would it obscure the configure output on failure? I would actually be in favor of attaching it as build artifact unconditionally...

[magicus]

I don't know what is your definition of "large". The relevant output is in the top of the file, and in the end all internal variables are dumped -- that is a bit annoying and I've never found it useful.

Here is an example on how it looks with a failed build: https://github.com/magicus/jdk/runs/8163132267?check_suite_focus=true

If you don't think this is good I can withdraw this PR, but I will not try to upload this as an artifact instead, that is way to much work for me to be bothered to do it. (My personal opinion is also that this is much more helpful, the current implementation of artifacts is very clumsy, and with this solution you can get the configure output and the config.log at the same place)

[magicus]

(A cool addition would rather be to create a "Summary" markdown that exposes both configure output and config.log in collapsible sections, like how test failures are presented)

[shipilev]

I don't know what is your definition of "large". The relevant output is in the top of the file, and in the end all internal variables are dumped -- that is a bit annoying and I've never found it useful.

Here is an example on how it looks with a failed build: https://github.com/magicus/jdk/runs/8163132267?check_suite_focus=true

Ah, that's not too bad. I thought it would completely obscure the configure log.

[openjdk]

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293361: GHA: dump config.log in case of configure failure

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• 1bed23a: 8293353: [BACKOUT] G1: Remove redundant is-marking-active checks in C1 barrier
• 4955835: 8282434: Leading combining diacritic character in string renders incorrectly
• ef20ffe: 8293159: Use try-with-resources in X11FontManager.registerFontDir
• 056ed48: 8293180: JQuery UI license file not updated
• dbb2c4b: 8288897: Clean up node dump code
• 9833c02: 8292946: GC lock/jni/jnilock001 test failed "assert(gch->gc_cause() == GCCause::_scavenge_alot || !gch->incremental_collection_failed()) failed: Twice in a row"
• d753658: 8293107: GHA: Bump to Ubuntu 22.04
• d4e3e69: 8293344: JDK-8242181 broke stack printing for non-attached threads
• 2c61efe: 8282648: Weaken the InflaterInputStream specification in order to allow faster Zip implementations

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[magicus]

/integrate

[openjdk]

Going to push as commit 8e22f2b.
Since your change was applied there have been 10 commits pushed to the master branch:

• b17758a: 8247283: Enable the new conformant preprocessor option in Visual Studio
• 1bed23a: 8293353: [BACKOUT] G1: Remove redundant is-marking-active checks in C1 barrier
• 4955835: 8282434: Leading combining diacritic character in string renders incorrectly
• ef20ffe: 8293159: Use try-with-resources in X11FontManager.registerFontDir
• 056ed48: 8293180: JQuery UI license file not updated
• dbb2c4b: 8288897: Clean up node dump code
• 9833c02: 8292946: GC lock/jni/jnilock001 test failed "assert(gch->gc_cause() == GCCause::_scavenge_alot || !gch->incremental_collection_failed()) failed: Twice in a row"
• d753658: 8293107: GHA: Bump to Ubuntu 22.04
• d4e3e69: 8293344: JDK-8242181 broke stack printing for non-attached threads
• 2c61efe: 8282648: Weaken the InflaterInputStream specification in order to allow faster Zip implementations

Your commit was automatically rebased without conflicts.

[openjdk]

@magicus Pushed as commit 8e22f2b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.