8295738: Automate javax/swing/JFileChooser/FileSizeCheck.java

[aivanov-jdk]

This automates the test added in #9327.

The test has a set of objects which store the size of the file and the expected displayed size, the file name is generated automatically. The pattern for the file names ensures the files are displayed in the expected order up to and including gigabytes, 10 digits. I added more test cases that the original test had to verify the displayed size is rounded up, an automatic test can easily verify more rows than a human can.

The finds the Details button in the file chooser and clicks it, then it finds the table, finds the row where the first file is displayed. The test compares the size displayed in the table to the expected one. If it doesn't match, an error is printed to stderr. All the file sizes are verified. The first error message, if any, is thrown to fail the test.

The test passes with the fix for JDK-8288882 and fails without it.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8295738: Automate javax/swing/JFileChooser/FileSizeCheck.java

Reviewers

• @kumarabhi006 (no known github.com user name / role)
• Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10802/head:pull/10802
$ git checkout pull/10802

Update a local copy of the PR:
$ git checkout pull/10802
$ git pull https://git.openjdk.org/jdk pull/10802/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10802

View PR using the GUI difftool:
$ git pr show -t 10802

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10802.diff

[bridgekeeper]

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@aivanov-jdk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (614b0977)
• 00: Full (1dc4e2b6)

[kumarabhi006]

I have verified the test, it's working fine.

[openjdk]

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295738: Automate javax/swing/JFileChooser/FileSizeCheck.java

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

• 2181042: 8295375: debug agent class tracking should not piggy back on the cbClassPrepare() callback
• f41711e: 8295650: JFR: jfr scrub should warn if an event type doesn't exist
• 0c13d66: 8295530: Update Zlib Data Compression Library to Version 1.2.13
• 15bebf9: 8295666: Linux x86 build fails after 8292591
• 5064718: 8294460: CodeSection::alignment checks for CodeBuffer::SECT_STUBS incorrectly
• 8b010e0: 8030616: sun/management/jmxremote/bootstrap/RmiBootstrapTest fails intermittently with cannot find a free port
• b35922b: 8295714: GHA ::set-output is deprecated and will be removed
• dfd2d83: 8295657: SA: Allow larger object alignments
• a345df2: 8280131: jcmd reports "Module jdk.jfr not found." when "jdk.management.jfr" is missing
• ef62b61: 8295703: RISC-V: Remove implicit noreg temp register arguments in MacroAssembler
• ... and 13 more: https://git.openjdk.org/jdk/compare/c08ff2c7b88e94885f6b4701654a9e47e49567b0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[aivanov-jdk]

/integrate

[openjdk]

Going to push as commit df81b3c.
Since your change was applied there have been 45 commits pushed to the master branch:

• 68cf248: 8295298: Automate javax/swing/JFileChooser/FileViewNPETest.java
• fefbddf: 8291443: Obsolete the PrintSharedDictionary flag
• 5b3de6e: 8284840: Update CLDR to Version 42.0
• 2f3f3b6: 8295792: Clean up old async close code
• 5ac6f18: 8290010: IGV: Fix UndoRedo Action
• c055dfc: 8294565: IGV: ClassCastException when clicking on an edge in the graph
• 3898385: 8295461: IGV: Wrong src/dest nodes highlighted for edge
• d50b6eb: 8295776: [JVMCI] Add x86 CPU flags for MPK and CET
• 5596d9a: 8288493: Document JDK specific system properties in jdk.httpserver
• 7a49c9b: 8295717: Minimize disabled warnings in accessibility native code
• ... and 35 more: https://git.openjdk.org/jdk/compare/c08ff2c7b88e94885f6b4701654a9e47e49567b0...master

Your commit was automatically rebased without conflicts.

[openjdk]

@aivanov-jdk Pushed as commit df81b3c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.