8302172: [JVMCI] HotSpotResolvedJavaMethodImpl.canBeInlined must respect ForceInline

[dougxc]

The implementation of HotSpotResolvedJavaMethodImpl.canBeInlined must return true for a method annotated with @ForceInline.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8302172: [JVMCI] HotSpotResolvedJavaMethodImpl.canBeInlined must respect ForceInline

Reviewers

• Dean Long (@dean-long - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12501/head:pull/12501
$ git checkout pull/12501

Update a local copy of the PR:
$ git checkout pull/12501
$ git pull https://git.openjdk.org/jdk pull/12501/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12501

View PR using the GUI difftool:
$ git pr show -t 12501

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12501.diff

[bridgekeeper]

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dougxc The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (5db4d07d)

[dean-long]

Should this use shouldBeInlined() instead? Would it make sense for shouldBeInlined() to return true but canBeInlined() returns false?

[dougxc]

Yes as shouldBeInlined boils down to calling CompilerOracle::should_inline which can return true even if Method::is_not_compilable returns false.

[dean-long]

Looks good.

[dougxc]

Thanks @dean-long .

/integrate

[openjdk]

@dougxc This pull request has not yet been marked as ready for integration.

[openjdk]

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8302172: [JVMCI] HotSpotResolvedJavaMethodImpl.canBeInlined must respect ForceInline

Reviewed-by: dlong

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

• 74b167b: 8301819: Enable continuations code by default
• 919a6da: 8301202: Port fdlibm log to Java
• 98e98e9: 8296322: javac: use methods to manage parser mode flags
• 84e4799: 8297292: java/nio/channels/FileChannel/FileExtensionAndMap.java is too slow
• 57798dd: 6595142: (spec) ByteArrayInputStream treats bytes, not characters
• 880f52f: 8301638: A number of nsk/jdi invokemethod tests should be converted to create virtual threads
• db1b48e: 8302167: Avoid allocating register in fast_lock()
• 582b943: 8278965: crash in SymbolTable::do_lookup
• 4539899: 8301480: Replace NULL with nullptr in os/posix
• 1428db7: 8301224: Replace NULL with nullptr in share/gc/shared/
• ... and 10 more: https://git.openjdk.org/jdk/compare/0aeebee284effe9abd0ed3cf2845430b40bb53bd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dougxc]

/integrate

[openjdk]

Going to push as commit 1ef9f65.
Since your change was applied there have been 20 commits pushed to the master branch:

• 74b167b: 8301819: Enable continuations code by default
• 919a6da: 8301202: Port fdlibm log to Java
• 98e98e9: 8296322: javac: use methods to manage parser mode flags
• 84e4799: 8297292: java/nio/channels/FileChannel/FileExtensionAndMap.java is too slow
• 57798dd: 6595142: (spec) ByteArrayInputStream treats bytes, not characters
• 880f52f: 8301638: A number of nsk/jdi invokemethod tests should be converted to create virtual threads
• db1b48e: 8302167: Avoid allocating register in fast_lock()
• 582b943: 8278965: crash in SymbolTable::do_lookup
• 4539899: 8301480: Replace NULL with nullptr in os/posix
• 1428db7: 8301224: Replace NULL with nullptr in share/gc/shared/
• ... and 10 more: https://git.openjdk.org/jdk/compare/0aeebee284effe9abd0ed3cf2845430b40bb53bd...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dougxc Pushed as commit 1ef9f65.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.