8305934: PPC64: Disable VMContinuations on Big Endian

[reinrich]

Disable VMContinuations on PPC64 big endian in general (not only on AIX) because there are known failures in jdk:jdk_loom tests.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8305934: PPC64: Disable VMContinuations on Big Endian

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)
• Tyler Steele (@backwaterred - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13449/head:pull/13449
$ git checkout pull/13449

Update a local copy of the PR:
$ git checkout pull/13449
$ git pull https://git.openjdk.org/jdk.git pull/13449/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13449

View PR using the GUI difftool:
$ git pr show -t 13449

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13449.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rrich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@reinrich The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[reinrich]

@backwaterred are you ok with disabling VMContinuations on PPC big endian in general (not only AIX)? This will simplify regression testing.

[mlbridge]

Webrevs

• 00: Full (3cd5cba7)

[TheRealMDoerr]

LGTM.

[openjdk]

@reinrich This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305934: PPC64: Disable VMContinuations on Big Endian

Reviewed-by: mdoerr, tsteele

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• 92521b1: 8305875: Test TraceVirtualThreadLocals should be run with continuations only
• 00eb348: 8305937: com/sun/jdi/SetLocalWhileThreadInNative.java fails with -XX:+TieredCompilation
• 1385c3d: 8305966: ProblemList com/sun/jdi/JdbLastErrorTest.java on windows-x64
• 90b4006: 8305847: Improve diagnosability and resilience of HttpClient::close tests
• d7dc474: 8305712: [MacOS] Deprecated Cocoa-NSEvent names
• e0620b8: 8296420: javac has long lines in its command-line help
• 6b9b7d1: 8304350: Font.getStringBounds calculates wrong width for TextAttribute.TRACKING other than 0.0
• 2060c8e: 8305688: jdk build --with-memory-size=1024 broken by JDK-8305100
• 646b666: 8305900: Use loopback IP addresses in security policy files of httpclient tests
• fb9a29d: 8305414: gtest/NMTGtests.java is failing various sub-tests
• ... and 4 more: https://git.openjdk.org/jdk/compare/bc15163386659bfd549576817b4efe7307261ea8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[backwaterred]

I'm not totally clear on the reason for making this change. Other than #13372, is there much work to do in order to enable Continuations on BE Linux? If there are more changes, then it makes sense to me to go ahead with this PR. Otherwise, I'd rather work with you to tweak #13372 to get Continuations working instead.

I don't want to stand in the way of progress, so I'm happy to support this change if you feel that it streamlines things. I'm just thinking that we are likely to undo these changes in a couple weeks.

[reinrich]

Yes we will undo the change but only when no issues are open. This is to reduce the noise. I lost a day analyzing test failures with #13372.

[backwaterred]

Sounds good. Thanks @reinrich.

[reinrich]

Thanks for the reviews @TheRealMDoerr and @backwaterred.
/integrate

[openjdk]

Going to push as commit 12358e6.
Since your change was applied there have been 18 commits pushed to the master branch:

• 287bb06: 8305902: (cs) Resolve default Charset only once in StreamEncoder and StreamDecoder
• 8a1639d: 8305936: JavaThread::create_system_thread_object has unused is_visible argument
• 76cda9f: 8255548: Missing coverage for javax.xml.crypto.dom.DOMCryptoContext
• b60604e: 8305794: Unused interface sun.security.util.PermissionFactory can be removed
• 92521b1: 8305875: Test TraceVirtualThreadLocals should be run with continuations only
• 00eb348: 8305937: com/sun/jdi/SetLocalWhileThreadInNative.java fails with -XX:+TieredCompilation
• 1385c3d: 8305966: ProblemList com/sun/jdi/JdbLastErrorTest.java on windows-x64
• 90b4006: 8305847: Improve diagnosability and resilience of HttpClient::close tests
• d7dc474: 8305712: [MacOS] Deprecated Cocoa-NSEvent names
• e0620b8: 8296420: javac has long lines in its command-line help
• ... and 8 more: https://git.openjdk.org/jdk/compare/bc15163386659bfd549576817b4efe7307261ea8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@reinrich Pushed as commit 12358e6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.