Skip to content

Conversation

@mpdonova
Copy link
Contributor

@mpdonova mpdonova commented Apr 17, 2023

I refactored tests in the test/jdk/javax/net/ssl directories to use the test template classes.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8306014: Update javax.net.ssl TLS tests to use SSLContextTemplate or SSLEngineTemplate

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13494/head:pull/13494
$ git checkout pull/13494

Update a local copy of the PR:
$ git checkout pull/13494
$ git pull https://git.openjdk.org/jdk.git pull/13494/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13494

View PR using the GUI difftool:
$ git pr show -t 13494

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13494.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 17, 2023

👋 Welcome back mpdonova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 17, 2023
@openjdk
Copy link

openjdk bot commented Apr 17, 2023

@mpdonova The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Apr 17, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 17, 2023

Webrevs

@mpdonova
Copy link
Contributor Author

mpdonova commented May 2, 2023

Could someone please review this PR? This directly related to #13495 as well.

Thanks!

Copy link
Member

@XueleiFan XueleiFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@XueleiFan
Copy link
Member

The checks are not fully passed. Please double check if the failures are related to this update.

@openjdk
Copy link

openjdk bot commented May 2, 2023

@mpdonova This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306014: Update javax.net.ssl TLS tests to use SSLContextTemplate or SSLEngineTemplate

Reviewed-by: xuelei

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 256 new commits pushed to the master branch:

  • fc76687: 8306836: Remove pinned tag for G1 heap regions
  • ccf91f8: 8306933: C2: "assert(false) failed: infinite loop" failure
  • e9807a4: 8306042: C2: failed: Missed optimization opportunity in PhaseCCP (adding LShift->Cast->Add notification)
  • fcb280a: 8305092: Improve Thread.sleep(millis, nanos) for sub-millisecond granularity
  • 891530f: 8307005: Make CardTableBarrierSet::initialize non-virtual
  • e0774be: 8306997: C2: "malformed control flow" assert due to missing safepoint on backedge with a switch
  • 462b1df: 8307106: Allow concurrent GCs to walk CLDG without ClassLoaderDataGraph_lock
  • c8f3756: 8306729: Add nominal descriptors of modules and packages to Constants API
  • 0b5b642: 8307150: RISC-V: Remove remaining StoreLoad barrier with UseCondCardMark for Serial/Parallel GC
  • 418a825: 8306466: Open source more AWT Drag & Drop related tests
  • ... and 246 more: https://git.openjdk.org/jdk/compare/c0b4957fcce530290fe3b1e730b593b6458285aa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@XueleiFan) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 2, 2023
@mpdonova
Copy link
Contributor Author

mpdonova commented May 2, 2023

The checks are not fully passed. Please double check if the failures are related to this update.

They are unrelated to these changes.

@mpdonova
Copy link
Contributor Author

mpdonova commented May 3, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 3, 2023
@openjdk
Copy link

openjdk bot commented May 3, 2023

@mpdonova
Your change (at version 1a01ad8) is now ready to be sponsored by a Committer.

@XueleiFan
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented May 3, 2023

Going to push as commit 705ad7d.
Since your change was applied there have been 257 commits pushed to the master branch:

  • 3930709: 8068925: Add @OverRide in javax.tools classes
  • fc76687: 8306836: Remove pinned tag for G1 heap regions
  • ccf91f8: 8306933: C2: "assert(false) failed: infinite loop" failure
  • e9807a4: 8306042: C2: failed: Missed optimization opportunity in PhaseCCP (adding LShift->Cast->Add notification)
  • fcb280a: 8305092: Improve Thread.sleep(millis, nanos) for sub-millisecond granularity
  • 891530f: 8307005: Make CardTableBarrierSet::initialize non-virtual
  • e0774be: 8306997: C2: "malformed control flow" assert due to missing safepoint on backedge with a switch
  • 462b1df: 8307106: Allow concurrent GCs to walk CLDG without ClassLoaderDataGraph_lock
  • c8f3756: 8306729: Add nominal descriptors of modules and packages to Constants API
  • 0b5b642: 8307150: RISC-V: Remove remaining StoreLoad barrier with UseCondCardMark for Serial/Parallel GC
  • ... and 247 more: https://git.openjdk.org/jdk/compare/c0b4957fcce530290fe3b1e730b593b6458285aa...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 3, 2023
@openjdk openjdk bot closed this May 3, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 3, 2023
@openjdk
Copy link

openjdk bot commented May 3, 2023

@XueleiFan @mpdonova Pushed as commit 705ad7d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants