-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8306014: Update javax.net.ssl TLS tests to use SSLContextTemplate or SSLEngineTemplate #13494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…SSLEngineTemplate
|
👋 Welcome back mpdonova! A progress list of the required criteria for merging this PR into |
|
Could someone please review this PR? This directly related to #13495 as well. Thanks! |
XueleiFan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
|
The checks are not fully passed. Please double check if the failures are related to this update. |
|
@mpdonova This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 256 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@XueleiFan) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
They are unrelated to these changes. |
|
/integrate |
|
/sponsor |
|
Going to push as commit 705ad7d.
Your commit was automatically rebased without conflicts. |
|
@XueleiFan @mpdonova Pushed as commit 705ad7d. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
I refactored tests in the test/jdk/javax/net/ssl directories to use the test template classes.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13494/head:pull/13494$ git checkout pull/13494Update a local copy of the PR:
$ git checkout pull/13494$ git pull https://git.openjdk.org/jdk.git pull/13494/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 13494View PR using the GUI difftool:
$ git pr show -t 13494Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13494.diff
Webrev
Link to Webrev Comment