Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8305942: Open source several AWT Focus related tests #13527

Closed
wants to merge 3 commits into from
Closed

8305942: Open source several AWT Focus related tests #13527

wants to merge 3 commits into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Apr 19, 2023 •
edited by openjdk bot
Loading

This opensources several other AWT Focus related tests.
CI runs are ok.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8305942: Open source several AWT Focus related tests

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13527/head:pull/13527
$ git checkout pull/13527

Update a local copy of the PR:
$ git checkout pull/13527
$ git pull https://git.openjdk.org/jdk.git pull/13527/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13527

View PR using the GUI difftool:
$ git pr show -t 13527

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13527.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 19, 2023

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 19, 2023
@openjdk
Copy link

openjdk bot commented Apr 19, 2023

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Apr 19, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 19, 2023 •
edited
Loading

Webrevs

turbanoff
turbanoff reviewed Apr 19, 2023
View reviewed changes
test/jdk/java/awt/Focus/TemporaryLostComponentDeadlock.java

Thread t1 = new Thread() {
public void run() {
synchronized(frame1) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
synchronized(frame1) {
synchronized (frame1) {

turbanoff
turbanoff reviewed Apr 19, 2023
View reviewed changes
test/jdk/java/awt/Focus/TemporaryLostComponentDeadlock.java
public void run() {
synchronized(frame1) {
frame1.dispose();
synchronized(frame1) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
synchronized(frame1) {
synchronized (frame1) {

turbanoff
turbanoff reviewed Apr 19, 2023
View reviewed changes
test/jdk/java/awt/Focus/TemporaryLostComponentDeadlock.java
}
};
try {
synchronized(frame1) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
synchronized(frame1) {
synchronized (frame1) {

turbanoff
turbanoff reviewed Apr 19, 2023
View reviewed changes
test/jdk/java/awt/Focus/TemporaryLostComponentDeadlock.java
t1.start();
frame1.wait();
}
} catch( InterruptedException ie) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
} catch( InterruptedException ie) {
} catch (InterruptedException ie) {

@openjdk
Copy link

openjdk bot commented Apr 20, 2023

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305942: Open source several AWT Focus related tests

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 158 new commits pushed to the master branch:

  • afd2501: 8306482: Remove unused Method AccessFlags
  • d6cf4aa: 8305874: Open source AWT Key, Text Event related tests
  • 9412c0a: 8297302: gtest/AsyncLogGtest.java fails AsyncLogTest.stdoutOutput_vm
  • 20b1d19: 8305746: InitializeEncoding should cache Charset object instead of charset name
  • 955abca: 8306483: (ch) Channels.newReader(ReadableByteChannel,Charset) refers to csName
  • c6a288d: 8305945: (zipfs) Opening a directory to get input stream produces incorrect exception message
  • 73018b3: 8306284: G1: Remove assertion in G1ScanHRForRegionClosure::do_claimed_block
  • 33a7978: 8306538: Zero variant build failure after JDK-8257967
  • 9c2e5b3: 8306459: s390x: Replace NULL to nullptr
  • 6a7dff3: 8305880: Loom: Avoid putting stale object pointers in oops
  • ... and 148 more: https://git.openjdk.org/jdk/compare/ce10460e94c03f178943fa44dafae18acc480094...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 20, 2023
@prsadhuk
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 21, 2023

Going to push as commit 8346ae2.
Since your change was applied there have been 163 commits pushed to the master branch:

  • 9a68d1d: 8306060: Open source few AWT Insets related tests
  • 2c70828: 8305236: Some LoadLoad barriers in the interpreter are unnecessary after JDK-8220051
  • ffb2494: 8305207: Calendar.aggregateStamp(int, int) return value can be simplified
  • 174c1a6: 4737887: (cal) API: Calendar methods taking field should document exceptions
  • f633623: 8306474: Move InstanceKlass read-only flags
  • afd2501: 8306482: Remove unused Method AccessFlags
  • d6cf4aa: 8305874: Open source AWT Key, Text Event related tests
  • 9412c0a: 8297302: gtest/AsyncLogGtest.java fails AsyncLogTest.stdoutOutput_vm
  • 20b1d19: 8305746: InitializeEncoding should cache Charset object instead of charset name
  • 955abca: 8306483: (ch) Channels.newReader(ReadableByteChannel,Charset) refers to csName
  • ... and 153 more: https://git.openjdk.org/jdk/compare/ce10460e94c03f178943fa44dafae18acc480094...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 21, 2023
@openjdk openjdk bot closed this Apr 21, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 21, 2023
@prsadhuk prsadhuk deleted the JDK-8305942 branch April 21, 2023 02:51
@openjdk
Copy link

openjdk bot commented Apr 21, 2023

@prsadhuk Pushed as commit 8346ae2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbanoff turbanoff turbanoff left review comments

@prrace prrace prrace approved these changes

Assignees
No one assigned
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prsadhuk @turbanoff @prrace