Skip to content

Conversation

@dougxc
Copy link
Member

@dougxc dougxc commented Apr 20, 2023

This PR fixes an issue where an Object[] value is allocated in the VM and passed to a parameter of type Class[].


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8306581: JVMCI tests failed when run with -XX:TypeProfileLevel=222 after JDK-8303431

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13566/head:pull/13566
$ git checkout pull/13566

Update a local copy of the PR:
$ git checkout pull/13566
$ git pull https://git.openjdk.org/jdk.git pull/13566/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13566

View PR using the GUI difftool:
$ git pr show -t 13566

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13566.diff

Webrev

Link to Webrev Comment

@dougxc dougxc marked this pull request as ready for review April 20, 2023 19:31
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 20, 2023

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 20, 2023
@openjdk
Copy link

openjdk bot commented Apr 20, 2023

@dougxc The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Apr 20, 2023
@openjdk
Copy link

openjdk bot commented Apr 20, 2023

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306581: JVMCI tests failed when run with -XX:TypeProfileLevel=222 after JDK-8303431

Reviewed-by: never, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 20, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 20, 2023

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@dougxc
Copy link
Member Author

dougxc commented Apr 21, 2023

Thanks for the review @tkrodriguez and @vnkozlov .

/integrate

@openjdk
Copy link

openjdk bot commented Apr 21, 2023

Going to push as commit fdaabd6.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 36ec05d: 8306430: Open source some AWT tests related to TextComponent and Toolkit
  • 8346ae2: 8305942: Open source several AWT Focus related tests
  • 9a68d1d: 8306060: Open source few AWT Insets related tests
  • 2c70828: 8305236: Some LoadLoad barriers in the interpreter are unnecessary after JDK-8220051
  • ffb2494: 8305207: Calendar.aggregateStamp(int, int) return value can be simplified
  • 174c1a6: 4737887: (cal) API: Calendar methods taking field should document exceptions

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 21, 2023
@openjdk openjdk bot closed this Apr 21, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 21, 2023
@openjdk
Copy link

openjdk bot commented Apr 21, 2023

@dougxc Pushed as commit fdaabd6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dougxc dougxc deleted the JDK-8306581 branch August 20, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants