Skip to content

Conversation

@TejeshR13
Copy link
Contributor

@TejeshR13 TejeshR13 commented May 5, 2023

Open source few AWT Miscellaneous ( Panel, Popup, robot and scrollbar) tests.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8306812: Open source several AWT Miscellaneous tests

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13828/head:pull/13828
$ git checkout pull/13828

Update a local copy of the PR:
$ git checkout pull/13828
$ git pull https://git.openjdk.org/jdk.git pull/13828/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13828

View PR using the GUI difftool:
$ git pr show -t 13828

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13828.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 5, 2023

👋 Welcome back tr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 5, 2023
@openjdk
Copy link

openjdk bot commented May 5, 2023

@TejeshR13 The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label May 5, 2023
@mlbridge
Copy link

mlbridge bot commented May 5, 2023

@TejeshR13
Copy link
Contributor Author

@prrace I have updated all the review comments. Could you please re-review the PR.

Copy link
Contributor

@prsadhuk prsadhuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also confirm mach5 is green with this change

@TejeshR13
Copy link
Contributor Author

CI testing is green after the updated fix.

@openjdk
Copy link

openjdk bot commented May 26, 2023

@TejeshR13 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306812: Open source several AWT Miscellaneous tests

Reviewed-by: psadhukhan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1038 new commits pushed to the master branch:

  • d3b9b36: 8308009: Generational ZGC: OOM before clearing all SoftReferences
  • bac02b6: 8305189: C2 failed "assert(_outcnt==1) failed: not unique"
  • 62537d2: 8299974: Replace NULL with nullptr in share/adlc/
  • f09345b: 8308931: Problemlist compiler/jvmci/TestUncaughtErrorInCompileMethod.java
  • 7c072db: 8308844: ProblemList gc/z/TestHighUsage.java with Generational ZGC on windows x64
  • 4becb7b: 8306137: Open source several AWT ScrollPane related tests
  • 199b1bf: 8308583: SIGSEGV in GraphKit::gen_checkcast
  • 46c4da7: 8159023: Engineering notation of DecimalFormat does not work as documented
  • ee321c7: 8308907: ProblemList java/awt/Toolkit/GetScreenInsetsCustomGC/GetScreenInsetsCustomGC.java on linux-x64
  • dc7683a: 8308073: ClassLoaderExt::append_boot_classpath should handle dynamic archive
  • ... and 1028 more: https://git.openjdk.org/jdk/compare/431e702b676e2c02224d60181c34b5fe97873d8b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 26, 2023
@TejeshR13
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 26, 2023

Going to push as commit c494770.
Since your change was applied there have been 1038 commits pushed to the master branch:

  • d3b9b36: 8308009: Generational ZGC: OOM before clearing all SoftReferences
  • bac02b6: 8305189: C2 failed "assert(_outcnt==1) failed: not unique"
  • 62537d2: 8299974: Replace NULL with nullptr in share/adlc/
  • f09345b: 8308931: Problemlist compiler/jvmci/TestUncaughtErrorInCompileMethod.java
  • 7c072db: 8308844: ProblemList gc/z/TestHighUsage.java with Generational ZGC on windows x64
  • 4becb7b: 8306137: Open source several AWT ScrollPane related tests
  • 199b1bf: 8308583: SIGSEGV in GraphKit::gen_checkcast
  • 46c4da7: 8159023: Engineering notation of DecimalFormat does not work as documented
  • ee321c7: 8308907: ProblemList java/awt/Toolkit/GetScreenInsetsCustomGC/GetScreenInsetsCustomGC.java on linux-x64
  • dc7683a: 8308073: ClassLoaderExt::append_boot_classpath should handle dynamic archive
  • ... and 1028 more: https://git.openjdk.org/jdk/compare/431e702b676e2c02224d60181c34b5fe97873d8b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 26, 2023
@openjdk openjdk bot closed this May 26, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 26, 2023
@openjdk
Copy link

openjdk bot commented May 26, 2023

@TejeshR13 Pushed as commit c494770.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

7 participants