JDK-8309297: Adjust ShenandoahHeap print_heap_regions_on

[MBaesken]

The ShenandoahHeap print_heap_regions_on method prints some brief description of the columns of the heap table, however the description is unsorted and seems to be not fully up to date.

Another thought - is the critical pins column (CP=critical pins) still needed or always 0 and obsolete now?

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8309297: Adjust ShenandoahHeap print_heap_regions_on

Reviewers

• Y. Srinivas Ramakrishna (@ysramakrishna - Reviewer) ⚠️ Review applies to 463e1e02
• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14264/head:pull/14264
$ git checkout pull/14264

Update a local copy of the PR:
$ git checkout pull/14264
$ git pull https://git.openjdk.org/jdk.git pull/14264/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14264

View PR using the GUI difftool:
$ git pr show -t 14264

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14264.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[MBaesken]

Btw I also considered to add a table header describing the columns, but was not sure if this is really desired?

[openjdk]

@MBaesken The following labels will be automatically applied to this pull request:

• hotspot-gc
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (4e96461f)
• 00: Full (463e1e02)

[TheRealMDoerr]

CP is still used by jni_GetPrimitiveArrayCritical and jni_GetStringCritical. (Object pinning for critical JNI natives was already removed by https://bugs.openjdk.org/browse/JDK-8233343.)

[kdnilsen]

Looks good to me. I believe we still need critical pins count.

[TheRealMDoerr]

Looks good to me. I believe we still need critical pins count.

Correct. I already checked that. See my comment above.

[ysramakrishna]

You can delete this line since what it used to print _seqnum_last_alloc_mutator appears to no longer be present in ShenandoahHeapRegion.

[MBaesken]

I removed the comment line.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309297: Adjust ShenandoahHeap print_heap_regions_on

Reviewed-by: ysr, mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 61 new commits pushed to the master branch:

• 01455a0: 8304878: ConcurrentModificationException in javadoc tool
• 7d25bf7: 8309419: RISC-V: Relax register constraint for AddReductionVF & AddReductionVD nodes
• 5146a58: 8309418: RISC-V: Make use of vl1r.v & vfabs.v pseudo-instructions where appropriate
• 41bf2ad: 8308875: java/awt/Toolkit/GetScreenInsetsCustomGC/GetScreenInsetsCustomGC.java failed with 'Cannot invoke "sun.awt.X11GraphicsDevice.getInsets()" because "device" is null'
• a7a0913: 8309346: Extend hs_err logging for all VM operations deriving from VM_GC_Operation
• 3b85f84: 8309340: Provide sctpHandleSocketErrorWithMessage
• 2e9eff5: 8309406: Change jdk.trackAllThreads to default to true
• 6d155a4: 8308167: SequencedMap::firstEntry throws NPE when first entry has null key or value
• 4b15349: 8304438: jcmd JVMTI.agent_load should obey EnableDynamicAgentLoading
• b3c9d67: 8309136: [JVMCI] add -XX:+UseGraalJIT flag
• ... and 51 more: https://git.openjdk.org/jdk/compare/d987176412b0a1812c9b99aaaeaf65ac96fa05be...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TheRealMDoerr]

LGTM.

[MBaesken]

Hi Kelvin, Y. S. Ramakrishna and Martin, thanks for the reviews.

[MBaesken]

/integrate

[openjdk]

Going to push as commit 9233dcc.
Since your change was applied there have been 85 commits pushed to the master branch:

• 749d480: 8305763: Parsing a URI with an underscore goes through a silent exception, negatively impacting performance
• 3ccb3c0: 8305906: HttpClient may use incorrect key when finding pooled HTTP/2 connection for IPv6 address
• a25b7b8: 8295976: GetThreadListStackTraces returns wrong state for blocked VirtualThread
• fadcd65: 8309527: Improve test proxy performance
• 0ed4af7: 8309472: IGV: Add dump_igv(custom_name) for improved debugging
• f1c7afc: 8306647: Implementation of Structured Concurrency (Preview)
• a08c5cb: 8307953: [AIX] C locale's font setting was changed by JEP 400
• 0ceb432: 8309570: ProblemList sun/security/pkcs11/Signature/TestRSAKeyLength.java
• 65bdbc7: 8309396: com/sun/jdi/JdbMethodExitTest.java fails with virtual threads due to a bug in determining the main thread id
• 4a75fd4: 8301553: Support Password-Based Cryptography in SunPKCS11
• ... and 75 more: https://git.openjdk.org/jdk/compare/d987176412b0a1812c9b99aaaeaf65ac96fa05be...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit 9233dcc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.