Skip to content

Conversation

@rgiulietti
Copy link
Contributor

@rgiulietti rgiulietti commented Jun 13, 2023

Trivial fix to working but unsupported use of {@inheritdoc}


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14452/head:pull/14452
$ git checkout pull/14452

Update a local copy of the PR:
$ git checkout pull/14452
$ git pull https://git.openjdk.org/jdk.git pull/14452/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14452

View PR using the GUI difftool:
$ git pr show -t 14452

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14452.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 13, 2023

👋 Welcome back rgiulietti! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 13, 2023
@openjdk
Copy link

openjdk bot commented Jun 13, 2023

@rgiulietti The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jun 13, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 13, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 13, 2023

@rgiulietti This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309955: Matcher uses @since {@inheritDoc}

Reviewed-by: lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • d7251c1: 8309757: com/sun/jdi/ReferrersTest.java fails with virtual test thread factory

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 13, 2023
@rgiulietti
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 13, 2023

Going to push as commit bfef3c3.
Since your change was applied there has been 1 commit pushed to the master branch:

  • d7251c1: 8309757: com/sun/jdi/ReferrersTest.java fails with virtual test thread factory

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 13, 2023
@openjdk openjdk bot closed this Jun 13, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 13, 2023
@openjdk
Copy link

openjdk bot commented Jun 13, 2023

@rgiulietti Pushed as commit bfef3c3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@rgiulietti
Copy link
Contributor Author

/backport jdk21

@openjdk
Copy link

openjdk bot commented Jun 13, 2023

@rgiulietti the backport was successfully created on the branch rgiulietti-backport-bfef3c3e in my personal fork of openjdk/jdk21. To create a pull request with this backport targeting openjdk/jdk21:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit bfef3c3e from the openjdk/jdk repository.

The commit being backported was authored by Raffaello Giulietti on 13 Jun 2023 and was reviewed by Lance Andersen.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21:

$ git fetch https://github.com/openjdk-bots/jdk21.git rgiulietti-backport-bfef3c3e:rgiulietti-backport-bfef3c3e
$ git checkout rgiulietti-backport-bfef3c3e
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21.git rgiulietti-backport-bfef3c3e

@rgiulietti rgiulietti deleted the 8309955 branch June 13, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants