Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8312147: Dynamic Exception Specification warnings are no longer required after JDK-8311380 #14899

Closed
wants to merge 2 commits into from

Conversation

TheShermanTanker
Copy link
Contributor

@TheShermanTanker TheShermanTanker commented Jul 17, 2023

After JDK-8311380, the dynamic exception specification warning pragma can be removed


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8312147: Dynamic Exception Specification warnings are no longer required after JDK-8311380 (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14899/head:pull/14899
$ git checkout pull/14899

Update a local copy of the PR:
$ git checkout pull/14899
$ git pull https://git.openjdk.org/jdk.git pull/14899/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14899

View PR using the GUI difftool:
$ git pr show -t 14899

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14899.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 17, 2023

👋 Welcome back jwaters! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 17, 2023
@openjdk
Copy link

openjdk bot commented Jul 17, 2023

@TheShermanTanker The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Jul 17, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 17, 2023

Webrevs

@mrserb
Copy link
Member

mrserb commented Jul 17, 2023

The log of the GA:

=== Output from failing command(s) repeated here ===

  • For target support_native_java.desktop_libawt_CmdIDList.obj:
    CmdIDList.cpp
    d:\a\jdk\jdk\src\java.desktop\windows\native\libawt\windows\awt_Toolkit.h(257): error C2220: the following warning is treated as an error
    d:\a\jdk\jdk\src\java.desktop\windows\native\libawt\windows\awt_Toolkit.h(257): warning C4290: C++ exception specification ignored except to indicate a function is not __declspec(nothrow)
    ... (rest of output omitted)

@TheShermanTanker
Copy link
Contributor Author

Oops, looks like 8311380 missed an exception specifier in awt_Toolkit.h. It should be ok now

Copy link
Contributor

@prrace prrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified the build on our CI systems.

/reviewers 2

@openjdk
Copy link

openjdk bot commented Jul 18, 2023

@TheShermanTanker This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312147: Dynamic Exception Specification warnings are no longer required after JDK-8311380

Reviewed-by: prr, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

  • af5bf81: 8310584: GetThreadState reports blocked and runnable for pinned suspended virtual threads
  • b4dce0d: 8310814: Clarify the targetName parameter of Lookup::findClass
  • 9905f75: 8311040: JFR: RecordedThread::getOSThreadId() should return -1 if thread is virtual
  • 1dfb0fb: 8311188: Simplify and modernize equals and hashCode in java.text
  • 1fc726a: 8312163: Crash in dominance check when compiling unnamed patterns
  • b20dc1e: 8310629: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java fails with RuntimeException Server not ready
  • 4b9ec82: 8310355: Move the stub test from initialize_final_stubs() to test/hotspot/gtest
  • 8ec136e: 8312072: Deprecate for removal the -Xnoagent option
  • fbe51e3: 8312127: FileDescriptor.sync should temporarily increase parallelism
  • 201e3bc: 8291065: Creating a VarHandle for a static field triggers class initialization
  • ... and 14 more: https://git.openjdk.org/jdk/compare/1c9691b1f762812aa090b88507d60a2e2e5f4933...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 18, 2023
@openjdk
Copy link

openjdk bot commented Jul 18, 2023

@prrace
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Jul 18, 2023
@prrace
Copy link
Contributor

prrace commented Jul 18, 2023

/reviewers 2

@openjdk
Copy link

openjdk bot commented Jul 18, 2023

@prrace
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 18, 2023
@TheShermanTanker
Copy link
Contributor Author

Thanks all for the reviews

@TheShermanTanker
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 19, 2023

Going to push as commit 702fea8.
Since your change was applied there have been 40 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 19, 2023
@openjdk openjdk bot closed this Jul 19, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 19, 2023
@openjdk
Copy link

openjdk bot commented Jul 19, 2023

@TheShermanTanker Pushed as commit 702fea8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheShermanTanker TheShermanTanker deleted the patch-6 branch July 19, 2023 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants