Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315485: (fs) Move java/nio/file/Path/Misc.java tests into java/nio/file/Path/PathOps.java #15572

Closed
wants to merge 4 commits into from

Conversation

bplb
Copy link
Member

@bplb bplb commented Sep 5, 2023

In the java/nio/file/Path tests, add to PathOps tests equivalent to those in Misc and then remove the latter.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315485: (fs) Move java/nio/file/Path/Misc.java tests into java/nio/file/Path/PathOps.java (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15572/head:pull/15572
$ git checkout pull/15572

Update a local copy of the PR:
$ git checkout pull/15572
$ git pull https://git.openjdk.org/jdk.git pull/15572/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15572

View PR using the GUI difftool:
$ git pr show -t 15572

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15572.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 5, 2023

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 5, 2023
@openjdk
Copy link

openjdk bot commented Sep 5, 2023

@bplb The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Sep 5, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 5, 2023

Webrevs

@bplb
Copy link
Member Author

bplb commented Sep 6, 2023

Moving to draft pending revision.

@bplb bplb marked this pull request as draft September 6, 2023 02:31
@openjdk openjdk bot removed the rfr Pull request is ready for review label Sep 6, 2023
@bplb bplb marked this pull request as ready for review September 6, 2023 15:26
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 6, 2023
@openjdk
Copy link

openjdk bot commented Sep 15, 2023

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315485: (fs) Move java/nio/file/Path/Misc.java tests into java/nio/file/Path/PathOps.java

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 155 new commits pushed to the master branch:

  • 3c743cf: 8312126: NullPointerException in CertStore.getCRLs after 8297955
  • bd26813: 8316295: Serial: Remove empty Generation::promotion_failure_occurred
  • 42dc6b5: 8316182: RISC-V: SA stack walking code having trouble finding sender frame when invoking LambdaForms is involved
  • 31c4e03: 8314551: More generic way to handshake GC threads with monitor deflation
  • 89cb290: 8312165: Fix typos in java.desktop Swing
  • 25f32f3: 8316160: Remove sun.misc.Unsafe.{shouldBeInitialized,ensureClassInitialized}
  • 86dde5e: 8316001: GC: Make TestArrayAllocatorMallocLimit use createTestJvm
  • 4f864fa: 8314136: Test java/net/httpclient/CancelRequestTest.java failed: WARNING: tracker for HttpClientImpl(42) has outstanding operations
  • 4070829: 8315931: RISC-V: xxxMaxVectorTestsSmokeTest fails when using RVV
  • d575968: 8316178: Better diagnostic header for CodeBlobs
  • ... and 145 more: https://git.openjdk.org/jdk/compare/939d7c5d8466f9e392beae2947a494ac28695cc1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 15, 2023
@bplb
Copy link
Member Author

bplb commented Sep 15, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Sep 15, 2023

Going to push as commit 8dfde28.
Since your change was applied there have been 155 commits pushed to the master branch:

  • 3c743cf: 8312126: NullPointerException in CertStore.getCRLs after 8297955
  • bd26813: 8316295: Serial: Remove empty Generation::promotion_failure_occurred
  • 42dc6b5: 8316182: RISC-V: SA stack walking code having trouble finding sender frame when invoking LambdaForms is involved
  • 31c4e03: 8314551: More generic way to handshake GC threads with monitor deflation
  • 89cb290: 8312165: Fix typos in java.desktop Swing
  • 25f32f3: 8316160: Remove sun.misc.Unsafe.{shouldBeInitialized,ensureClassInitialized}
  • 86dde5e: 8316001: GC: Make TestArrayAllocatorMallocLimit use createTestJvm
  • 4f864fa: 8314136: Test java/net/httpclient/CancelRequestTest.java failed: WARNING: tracker for HttpClientImpl(42) has outstanding operations
  • 4070829: 8315931: RISC-V: xxxMaxVectorTestsSmokeTest fails when using RVV
  • d575968: 8316178: Better diagnostic header for CodeBlobs
  • ... and 145 more: https://git.openjdk.org/jdk/compare/939d7c5d8466f9e392beae2947a494ac28695cc1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 15, 2023
@openjdk openjdk bot closed this Sep 15, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 15, 2023
@openjdk
Copy link

openjdk bot commented Sep 15, 2023

@bplb Pushed as commit 8dfde28.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bplb bplb deleted the Misc-PathOps-8315485 branch September 22, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated nio nio-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants