JDK-8283140: Remove unused encoding classes/operands from x86_64.ad

[JohnTortugo]

These encoding classes became dead code when the instructions' definitions were patched to use the MacroAssembler.

Tested with tier 1-3 on Linux, Windows & MacOS.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8283140: Remove unused encoding classes/operands from x86_64.ad (Sub-task - P4)

Reviewers

• Tobias Hartmann (@TobiHartmann - Reviewer) ⚠️ Review applies to e816b9e5
• Dean Long (@dean-long - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16319/head:pull/16319
$ git checkout pull/16319

Update a local copy of the PR:
$ git checkout pull/16319
$ git pull https://git.openjdk.org/jdk.git pull/16319/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16319

View PR using the GUI difftool:
$ git pr show -t 16319

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16319.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cslucas! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@JohnTortugo The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 06: Full - Incremental (b49aa52d)
• 05: Full - Incremental (8e64c93e)
• 04: Full - Incremental (d34e4709)
• 03: Full - Incremental (e32a421a)
• 02: Full - Incremental (e816b9e5)
• 01: Full - Incremental (d6199348)
• 00: Full (aef060d2)

[TobiHartmann]

Looks good to me.

[openjdk]

@JohnTortugo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283140: Remove unused encoding classes/operands from x86_64.ad

Reviewed-by: thartmann, dlong

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 555 new commits pushed to the master branch:

• ffa35d8: 8301997: Move method resolution information out of the cpCache
• 891d8cf: 8319986: Invalid/inconsistent description and example for DateFormat
• 536b1ce: 8320130: Problemlist 2 vmTestbase/nsk/jdi/StepRequest/addClassFilter_rt tests with Xcomp
• 0bda467: 8319187: Add three eMudhra emSign roots
• 3c6ffca: 8318219: RISC-V: C2 ExpandBits
• 77a6966: 8320053: GHA: Cross-compile gtest code
• 4f4d00f: 8319966: AIX: expected [[0:i4]] but found [[0:I4]] after JDK-8319882
• 2e34a2e: 8318671: Potential uninitialized uintx value after JDK-8317683
• fac6b51: 8319781: RISC-V: Refactor UseRVV related checks
• bad6999: 8313672: C2: PhaseCCP does not correctly track analysis dependencies involving shift, convert, and mask
• ... and 545 more: https://git.openjdk.org/jdk/compare/b859da9c548fbd1463b336059d1c55312c7b7ba4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TobiHartmann, @dean-long) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[JohnTortugo]

/integrate

[openjdk]

@JohnTortugo
Your change (at version e816b9e) is now ready to be sponsored by a Committer.

[JohnTortugo]

I need a sponsor to be able to merge this. Is anyone brave enough?

[offamitkumar]

I guess you need one more approval before integration.

[JohnTortugo]

@reviewers is there anything else I should address here?

[dean-long]

Looks good. Nice improvement.

[JohnTortugo]

Thank you all for reviewing!

[JohnTortugo]

/integrate

[openjdk]

@JohnTortugo
Your change (at version b49aa52) is now ready to be sponsored by a Committer.

[TobiHartmann]

/sponsor

[openjdk]

Going to push as commit 3452210.
Since your change was applied there have been 556 commits pushed to the master branch:

• f0b7eb5: 8304020: Speed up test/jdk/java/util/zip/ZipFile/TestTooManyEntries.java and clarify its purpose
• ffa35d8: 8301997: Move method resolution information out of the cpCache
• 891d8cf: 8319986: Invalid/inconsistent description and example for DateFormat
• 536b1ce: 8320130: Problemlist 2 vmTestbase/nsk/jdi/StepRequest/addClassFilter_rt tests with Xcomp
• 0bda467: 8319187: Add three eMudhra emSign roots
• 3c6ffca: 8318219: RISC-V: C2 ExpandBits
• 77a6966: 8320053: GHA: Cross-compile gtest code
• 4f4d00f: 8319966: AIX: expected [[0:i4]] but found [[0:I4]] after JDK-8319882
• 2e34a2e: 8318671: Potential uninitialized uintx value after JDK-8317683
• fac6b51: 8319781: RISC-V: Refactor UseRVV related checks
• ... and 546 more: https://git.openjdk.org/jdk/compare/b859da9c548fbd1463b336059d1c55312c7b7ba4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TobiHartmann @JohnTortugo Pushed as commit 3452210.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.