Skip to content

8324613: Serial: Rename GenerationPool to TenuredGenerationPool #17551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
albertnetymk wants to merge 2 commits into from
Closed

8324613: Serial: Rename GenerationPool to TenuredGenerationPool #17551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15114d6
s1-old-gen-pool
albertnetymk Jan 24, 2024
da42514
review
albertnetymk Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/hotspot/share/gc/serial/serialHeap.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ void SerialHeap::initialize_serviceability() {
young->max_survivor_size(),
false /* support_usage_threshold */);
TenuredGeneration* old = old_gen();
_old_pool = new GenerationPool(old, "Tenured Gen", true);
_old_pool = new TenuredGenerationPool(old, "Tenured Gen", true);

_young_manager->add_pool(_eden_pool);
_young_manager->add_pool(_survivor_pool);
Expand Down
12 changes: 6 additions & 6 deletions src/hotspot/share/gc/serial/serialMemoryPools.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@

#include "precompiled.hpp"
#include "gc/serial/defNewGeneration.hpp"
#include "gc/serial/generation.hpp"
#include "gc/serial/serialMemoryPools.hpp"
#include "gc/serial/tenuredGeneration.hpp"
#include "gc/shared/space.hpp"

ContiguousSpacePool::ContiguousSpacePool(ContiguousSpace* space,
Expand Down Expand Up @@ -72,18 +72,18 @@ MemoryUsage SurvivorContiguousSpacePool::get_memory_usage() {
return MemoryUsage(initial_size(), used, committed, maxSize);
}

GenerationPool::GenerationPool(Generation* gen,
const char* name,
bool support_usage_threshold) :
TenuredGenerationPool::TenuredGenerationPool(TenuredGeneration* gen,
const char* name,
bool support_usage_threshold) :
CollectedMemoryPool(name, gen->capacity(), gen->max_capacity(),
support_usage_threshold), _gen(gen) {
}

size_t GenerationPool::used_in_bytes() {
size_t TenuredGenerationPool::used_in_bytes() {
return _gen->used();
}

MemoryUsage GenerationPool::get_memory_usage() {
MemoryUsage TenuredGenerationPool::get_memory_usage() {
size_t used = used_in_bytes();
size_t committed = _gen->capacity();
size_t maxSize = (available_for_allocation() ? max_size() : 0);
Expand Down
6 changes: 3 additions & 3 deletions src/hotspot/share/gc/serial/serialMemoryPools.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,11 @@ class SurvivorContiguousSpacePool : public CollectedMemoryPool {
size_t committed_in_bytes();
};

class GenerationPool : public CollectedMemoryPool {
class TenuredGenerationPool : public CollectedMemoryPool {
private:
Generation* _gen;
TenuredGeneration* _gen;
public:
GenerationPool(Generation* gen, const char* name, bool support_usage_threshold);
TenuredGenerationPool(TenuredGeneration* gen, const char* name, bool support_usage_threshold);

MemoryUsage get_memory_usage();
size_t used_in_bytes();
Expand Down