8327383: Clean up _Stalled and _Spinner fields

[fbredber]

Removed the _Stalled and the _Spinner fields from the object synchronization code, since they are not used anymore.

Passes tier1-5

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8327383: Clean up _Stalled and _Spinner fields (Enhancement - P4)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Coleen Phillimore (@coleenp - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18306/head:pull/18306
$ git checkout pull/18306

Update a local copy of the PR:
$ git checkout pull/18306
$ git pull https://git.openjdk.org/jdk.git pull/18306/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18306

View PR using the GUI difftool:
$ git pr show -t 18306

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18306.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fbredberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@fbredber This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327383: Clean up _Stalled and _Spinner fields

Reviewed-by: dholmes, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 194 new commits pushed to the master branch:

• c342188: 8328074: Add jcheck whitespace checking for assembly files
• 3c70f26: 8328112: Remove CardTable::_guard_region
• 48717d6: 8326333: jshell completion on arrays is incomplete
• ece4124: 8328247: Remove redundant dir for tests converted from applet to main
• d32ce65: 8327651: Rename DictionaryEntry members related to protection domain
• 0719419: 8328236: module_entry in CDS map file has stale value
• 0204aac: 8328115: Convert java/awt/font/TextLayout/TestJustification.html applet test to main
• 9bc1b06: 8328242: Add a log area to the PassFailJFrame
• 65a84c2: 8328006: refactor large anonymous inner class in HtmlDocletWriter
• 044f4ed: 8326979: (jdeps) improve the error message for FindException caused by InvalidModuleDescriptorException
• ... and 184 more: https://git.openjdk.org/jdk/compare/e9adcebaf242843fe2004b01747b5a930b62b291...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dholmes-ora, @coleenp) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@fbredber The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (0c098fb1)

[dholmes-ora]

LGTM! Thanks

[coleenp]

Thanks for cleaning these up.

[fbredber]

Thanks for the review.

[fbredber]

/integrate

[openjdk]

@fbredber
Your change (at version 0c098fb) is now ready to be sponsored by a Committer.

[coleenp]

/sponsor

[openjdk]

@coleenp @fbredber An unexpected error occurred during sponsored integration. No push attempt will be made. The error has been logged and will be investigated. It is possible that this error is caused by a transient issue; feel free to retry the operation.

[coleenp]

/sponsor

[openjdk]

Going to push as commit 991e04e.
Since your change was applied there have been 369 commits pushed to the master branch:

• 4eefda9: 8327779: Remove deprecated internal field sun.security.x509.X509Key.key
• 341dd57: 8325883: Move Monitor Deflation reporting out of safepoint cleanup
• 7ac2f91: 8329210: Delete Redundant Printer Dialog Modality Test
• 85cb4a9: 8247449: Revisit the argument processing logic for MetaspaceShared::disable_optimized_module_handling()
• aa595db: 8328507: Move StackWatermark code from safepoint cleanup
• 2af0312: 8328619: sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.java failed with BindException: Address already in use
• 7c7b961: 8329191: JVMCI compiler warning is truncated
• 2b79c22: 8327505: Test com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.java fails
• 47f33a5: 8327986: ASAN reports use-after-free in DirectivesParserTest.empty_object_vm
• d580bcf: 8329178: Clean up jdk.accessibility native compilation
• ... and 359 more: https://git.openjdk.org/jdk/compare/e9adcebaf242843fe2004b01747b5a930b62b291...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp @fbredber Pushed as commit 991e04e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.