8334394: Race condition in Class::protectionDomain

[wangweij]

Make sure pd is always the same object when getProtectionDomain0 is null.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8334394: Race condition in Class::protectionDomain (Bug - P4)

Reviewers

• Chen Liang (@liach - Reviewer)
• Jaikiran Pai (@jaikiran - Reviewer)
• Alan Bateman (@AlanBateman - Reviewer) 🔄 Re-review required (review applies to 4ce5bc24)
• Roger Riggs (@RogerRiggs - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19752/head:pull/19752
$ git checkout pull/19752

Update a local copy of the PR:
$ git checkout pull/19752
$ git pull https://git.openjdk.org/jdk.git pull/19752/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19752

View PR using the GUI difftool:
$ git pr show -t 19752

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19752.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334394: Race condition in Class::protectionDomain

Reviewed-by: liach, jpai, rriggs, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 418 new commits pushed to the master branch:

• 92de2b2: 8336039: Doccheck: HTML warnings, broken links and missing files in java.base documentation
• 7ddd025: 4265389: JSplitPane does not support ComponentOrientation
• c1fdc04: 8336781: Erroneous exhaustivity check with boolean switch
• 0db6c15: 8336833: Endless loop in Javap ClassWriter
• 4da9915: 8333396: Use StringBuilder internally for java.text.Format.* formatting
• fd741a8: 8327538: The SSLExtension class specifies incorrect values for heartbeat per RFC 6520 and post_handshake_auth per RFC 8446
• ad498f5: 8335896: Source launcher should set TCCL
• b21cb44: 8329398: Links in InetAddress class description show "#format"
• c5b7af7: 8336692: Redo fix for JDK-8284620
• 491b9f5: 8336706: Optimize LocalDate.toString with StringBuilder.repeat
• ... and 408 more: https://git.openjdk.org/jdk/compare/cff048c7354dd947a3946d262f4752a55b7e2a43...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@wangweij The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (ed2ba88a)
• 01: Full - Incremental (4ce5bc24)
• 00: Full (637cf0df)

[liach]

Looks great! I just wonder about how we usually write tests for such races, as these races may be platform-dependent and the test might not be able to always reproduce the race (such as with number of threads).

[AlanBateman]

The update to Class looks okay. At some point (after SM removal) then I think we should see if the protection domain field can be changed to be an explicit field (not injected) so that the native method and JVM_GetProtectionDomain can be removed.

[liach]

I think the move of protectionDomain and signers fields from injected to explicit should be done in a separate RFE: created https://bugs.openjdk.org/browse/JDK-8334772 to track that.

[RogerRiggs]

lgtm

[jaikiran]

Still looks good to me.

[wangweij]

/integrate

[openjdk]

Going to push as commit c3226aa.
Since your change was applied there have been 418 commits pushed to the master branch:

• 92de2b2: 8336039: Doccheck: HTML warnings, broken links and missing files in java.base documentation
• 7ddd025: 4265389: JSplitPane does not support ComponentOrientation
• c1fdc04: 8336781: Erroneous exhaustivity check with boolean switch
• 0db6c15: 8336833: Endless loop in Javap ClassWriter
• 4da9915: 8333396: Use StringBuilder internally for java.text.Format.* formatting
• fd741a8: 8327538: The SSLExtension class specifies incorrect values for heartbeat per RFC 6520 and post_handshake_auth per RFC 8446
• ad498f5: 8335896: Source launcher should set TCCL
• b21cb44: 8329398: Links in InetAddress class description show "#format"
• c5b7af7: 8336692: Redo fix for JDK-8284620
• 491b9f5: 8336706: Optimize LocalDate.toString with StringBuilder.repeat
• ... and 408 more: https://git.openjdk.org/jdk/compare/cff048c7354dd947a3946d262f4752a55b7e2a43...master

Your commit was automatically rebased without conflicts.

[openjdk]

@wangweij Pushed as commit c3226aa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.