-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8333843: Provide guidelines on MemorySegment to read strings with known lengths #20725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back pminborg! A progress list of the required criteria for merging this PR into |
|
@minborg This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 31 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
src/java.base/share/classes/java/lang/foreign/MemorySegment.java
Outdated
Show resolved
Hide resolved
src/java.base/share/classes/java/lang/foreign/MemorySegment.java
Outdated
Show resolved
Hide resolved
src/java.base/share/classes/jdk/internal/foreign/StringSupport.java
Outdated
Show resolved
Hide resolved
src/java.base/share/classes/java/lang/foreign/MemorySegment.java
Outdated
Show resolved
Hide resolved
src/java.base/share/classes/java/lang/foreign/MemorySegment.java
Outdated
Show resolved
Hide resolved
src/java.base/share/classes/java/lang/foreign/MemorySegment.java
Outdated
Show resolved
Hide resolved
mcimadamore
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good
|
/integrate |
|
Going to push as commit 3e0da58.
Your commit was automatically rebased without conflicts. |
This PR proposes to add a new overload to
MemorySegment::getStringwhereby it is possible to pass in a known byte length of the content in a segment that should be converted to a String. This is useful in case one already knows the byte length and thereby does not need to scan for a null terminator.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20725/head:pull/20725$ git checkout pull/20725Update a local copy of the PR:
$ git checkout pull/20725$ git pull https://git.openjdk.org/jdk.git pull/20725/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 20725View PR using the GUI difftool:
$ git pr show -t 20725Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20725.diff
Webrev
Link to Webrev Comment