8339148: Make os::Linux::active_processor_count() public

[jerboaa]

Please review this Linux-only change which makes os::Linux::active_processor_count() public (from currently protected). This allows us to clean up some friend class usages and will also make some container related patches less clunky.

Testing:

• GHA
• Container tests on linux x86_64

Thoughts?

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8339148: Make os::Linux::active_processor_count() public (Enhancement - P3)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Julian Waters (@TheShermanTanker - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20833/head:pull/20833
$ git checkout pull/20833

Update a local copy of the PR:
$ git checkout pull/20833
$ git pull https://git.openjdk.org/jdk.git pull/20833/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20833

View PR using the GUI difftool:
$ git pr show -t 20833

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20833.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jerboaa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339148: Make os::Linux::active_processor_count() public

Reviewed-by: dholmes, jwaters

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

• e25a9e7: 8339486: JFR: Modernize
• 4e2dde2: 8339371: jlink.log warning when building after JDK-8338404
• 7ad6160: 8339163: ZGC: Race in clearing of remembered sets
• a618605: 8339399: ZGC: Remove unnecessary page reset when splitting pages
• f2c992c: 8339300: CollectorPolicy.young_scaled_initial_ergo_vm gtest fails on ppc64 based platforms
• 9a1024d: 8190329: [macos] Swing InterOp Platform.exit() crash
• 5998f4b: 8308588: Unnecessary synchronized on GTKStyle#ICONS_MAP can be removed
• 90f3f43: 8328877: [JNI] The JNI Specification needs to address the limitations of integer UTF-8 String lengths
• bbb5161: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs
• a22e932: 8337163: Improve SA error message when failing to attach to a core file
• ... and 14 more: https://git.openjdk.org/jdk/compare/6f3e3fd0d4f5e80e3fdbd26be6483c672479802a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@jerboaa The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[jerboaa]

/cc @tstuefe

[openjdk]

@jerboaa
The label @tstuefe is not a valid label.
These labels are valid:

• graal
• serviceability
• hotspot
• hotspot-compiler
• ide-support
• kulla
• i18n
• shenandoah
• jdk
• javadoc
• security
• hotspot-runtime
• jmx
• build
• nio
• client
• core-libs
• compiler
• net
• hotspot-gc
• hotspot-jfr

[mlbridge]

Webrevs

• 00: Full (51ece08c)

[dholmes-ora]

This is fine.

Thanks

[jerboaa]

Thanks for the review!

[jerboaa]

Do I need a second review for this or is this trivial enough to go in with one review?

[TheShermanTanker]

Looks good

[TheShermanTanker]

@jerboaa The label @tstuefe is not a valid label. These labels are valid:

• graal
• serviceability
• hotspot
• hotspot-compiler
• ide-support
• kulla
• i18n
• shenandoah
• jdk
• javadoc
• security
• hotspot-runtime
• jmx
• build
• nio
• client
• core-libs
• compiler
• net
• hotspot-gc
• hotspot-jfr

Bahahahahaha - Probably the funniest thing I've seen in a while

[jerboaa]

Thanks for the reviews! I'll integrate later today.

[jerboaa]

/integrate

[openjdk]

Going to push as commit 12d060a.
Since your change was applied there have been 28 commits pushed to the master branch:

• 0cfd08f: 8339112: Move JVM Klass flags out of AccessFlags
• 6f8714e: 8336860: x86: Change integer src operand for CMoveL of 0 and 1 to long
• c7d15f1: 8325679: Optimize ArrayList subList sort
• bd8569b: 8339131: Remove rarely-used accessor methods from Opcode
• e25a9e7: 8339486: JFR: Modernize
• 4e2dde2: 8339371: jlink.log warning when building after JDK-8338404
• 7ad6160: 8339163: ZGC: Race in clearing of remembered sets
• a618605: 8339399: ZGC: Remove unnecessary page reset when splitting pages
• f2c992c: 8339300: CollectorPolicy.young_scaled_initial_ergo_vm gtest fails on ppc64 based platforms
• 9a1024d: 8190329: [macos] Swing InterOp Platform.exit() crash
• ... and 18 more: https://git.openjdk.org/jdk/compare/6f3e3fd0d4f5e80e3fdbd26be6483c672479802a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jerboaa Pushed as commit 12d060a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[tstuefe]

I saw this too late. Thanks for doing this!