-
Notifications
You must be signed in to change notification settings - Fork 6.2k
6672644: JComboBox still scrolling if switch to another window and return back #20845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0cc3caf
Initial commit
DamonGuy 312c484
Review comments
DamonGuy d8cbd77
Initial commit
DamonGuy 675db52
Merge branch 'master' into 6672644/focusScroll
DamonGuy 2dbba1a
Update fix to resolve button pressed appearance. Handle review comments
DamonGuy 83669d5
Add space
DamonGuy c2b4389
Review comments
DamonGuy 2f6566c
isPressed check and set
DamonGuy 22105a3
Merge branch 'master' into 6672644/focusScroll
DamonGuy 0b1ae7a
Review comments
DamonGuy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
75 changes: 75 additions & 0 deletions
75
test/jdk/javax/swing/JComboBox/JComboBoxScrollFocusTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| /* | ||
| * Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved. | ||
| * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
| * | ||
| * This code is free software; you can redistribute it and/or modify it | ||
| * under the terms of the GNU General Public License version 2 only, as | ||
| * published by the Free Software Foundation. | ||
| * | ||
| * This code is distributed in the hope that it will be useful, but WITHOUT | ||
| * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
| * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
| * version 2 for more details (a copy is included in the LICENSE file that | ||
| * accompanied this code). | ||
| * | ||
| * You should have received a copy of the GNU General Public License version | ||
| * 2 along with this work; if not, write to the Free Software Foundation, | ||
| * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
| * | ||
| * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
| * or visit www.oracle.com if you need additional information or have any | ||
| * questions. | ||
| */ | ||
|
|
||
| import javax.swing.JComboBox; | ||
| import javax.swing.JFrame; | ||
|
|
||
| /* | ||
| * @test | ||
| * @bug 6672644 | ||
| * @library /java/awt/regtesthelpers | ||
| * @build PassFailJFrame | ||
| * @summary Tests JComboBox scrollbar behavior when alt-tabbing | ||
| * @requires os.family != "mac" | ||
| * @run main/manual JComboBoxScrollFocusTest | ||
| */ | ||
|
|
||
| public class JComboBoxScrollFocusTest { | ||
| private static final String INSTRUCTIONS = | ||
| """ | ||
| Click on the dropdown button for the JComboBox in the test frame. | ||
| Then, press and hold the left click button on the down arrow button | ||
| in the popup list. While holding the left click button, the list | ||
| should be scrolling down. Press ALT + TAB while holding down the | ||
| left click to switch focus to a different window. Then release the | ||
| left click button. Focus the test frame again and click the | ||
| dropdown button for the JComboBox again. The list should be | ||
| stationary and not be automatically scrolling. | ||
|
|
||
| If you are able to execute all steps successfully then the test | ||
| passes, otherwise it fails. | ||
| """; | ||
|
|
||
| public static void main(String[] args) throws Exception { | ||
| PassFailJFrame | ||
| .builder() | ||
| .title("JComboBoxScrollFocusTest Test Instructions") | ||
| .instructions(INSTRUCTIONS) | ||
| .columns(40) | ||
| .testUI(JComboBoxScrollFocusTest::createAndShowGUI) | ||
| .build() | ||
| .awaitAndCheck(); | ||
| } | ||
|
|
||
| private static JFrame createAndShowGUI() { | ||
| JFrame frame = new JFrame("JComboBoxScrollFocusTest Test Frame"); | ||
| JComboBox<String> combobox = new JComboBox<>(); | ||
| for (int i = 0; i < 100; i++) { | ||
| combobox.addItem(String.valueOf(i)); | ||
| } | ||
| frame.add(combobox); | ||
| frame.setSize(400, 200); | ||
| frame.setLocationRelativeTo(null); | ||
| return frame; | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.