8339696: Clarify modeling scope of javax.lang.model.element

[jddarcy]

Clarify that while javax.lang.model does not include an AST API, it is intended to be usable by an AST API.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8339696: Clarify modeling scope of javax.lang.model.element (Enhancement - P4)

Reviewers

• Jan Lahoda (@lahodaj - Reviewer) Review applies to 2c213737
• @abdelhak-zaaim (no known openjdk.org user name / role) Review applies to 2c213737
• Pavel Rappo (@pavelrappo - Reviewer) Review applies to 2c213737
• Jonathan Gibbons (@jonathan-gibbons - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20900/head:pull/20900
$ git checkout pull/20900

Update a local copy of the PR:
$ git checkout pull/20900
$ git pull https://git.openjdk.org/jdk.git pull/20900/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20900

View PR using the GUI difftool:
$ git pr show -t 20900

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20900.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339696: Clarify modeling scope of javax.lang.model.element

Reviewed-by: jjg, jlahoda, prappo

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

• 77468c2: 8339575: DumpingWithJavaAgent.java failed with missing expected output
• 86a2f9c: 8339644: Improve parsing of Day/Month in tzdata rules
• a9bb043: 8339683: Simplify class data generation in InvokerBytecodeGenerator
• 7c0f013: 8339488: Extended NPE message doesn't handle CONSTANT_Dynamic
• d53e405: 8339742: Refactor ClassFileImpl to allow loading Option classes lazily
• c54fc08: 8338587: Internal XOF Methods for SHAKE128 and SHAKE256
• 88cccc1: 8339631: Fix block @jls and @JVMS tags
• 615a24f: 8338902: CDS flags are reported with wrong flag category
• 347d572: 8339387: ZGC: Synchronize medium page allocation
• 4ff72dc: 8339487: ProcessHandleImpl os_getChildren sysctl call - retry in case of ENOMEM and enhance exception message
• ... and 6 more: https://git.openjdk.org/jdk/compare/fbe2629303bcee5855673b7e37d8c49f19dc9849...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@jddarcy The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (53c187db)
• 01: Full - Incremental (ac8ac995)
• 00: Full (2c213737)

[lahodaj]

Looks good to me.

[pavelrappo]

Looks good.

[jonathan-gibbons]

I suggest changing the (definite article) to something less definite, like any.
This would then correspond to the grammar on line 41 "an AST API"

[jddarcy]

/integrate

[openjdk]

Going to push as commit 6b5958d.
Since your change was applied there have been 16 commits pushed to the master branch:

• 77468c2: 8339575: DumpingWithJavaAgent.java failed with missing expected output
• 86a2f9c: 8339644: Improve parsing of Day/Month in tzdata rules
• a9bb043: 8339683: Simplify class data generation in InvokerBytecodeGenerator
• 7c0f013: 8339488: Extended NPE message doesn't handle CONSTANT_Dynamic
• d53e405: 8339742: Refactor ClassFileImpl to allow loading Option classes lazily
• c54fc08: 8338587: Internal XOF Methods for SHAKE128 and SHAKE256
• 88cccc1: 8339631: Fix block @jls and @JVMS tags
• 615a24f: 8338902: CDS flags are reported with wrong flag category
• 347d572: 8339387: ZGC: Synchronize medium page allocation
• 4ff72dc: 8339487: ProcessHandleImpl os_getChildren sysctl call - retry in case of ENOMEM and enhance exception message
• ... and 6 more: https://git.openjdk.org/jdk/compare/fbe2629303bcee5855673b7e37d8c49f19dc9849...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jddarcy Pushed as commit 6b5958d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.