Skip to content

8341831: PhaseCFG::insert_anti_dependences asserts with "no loads" #21455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
+11 −3
Closed

8341831: PhaseCFG::insert_anti_dependences asserts with "no loads" #21455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1843538
8341831: PhaseCFG::insert_anti_dependences asserts with "no loads"
veresov Oct 10, 2024
b8e0d8b
Remove the test from the problem list
veresov Oct 10, 2024
ae69ee4
Add comment
veresov Oct 10, 2024
914b97a
Address Dean's comment
veresov Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/hotspot/share/opto/gcm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -763,7 +763,17 @@ Block* PhaseCFG::insert_anti_dependences(Block* LCA, Node* load, bool verify) {
worklist_def_use_mem_states.pop();

uint op = use_mem_state->Opcode();
assert(!use_mem_state->needs_anti_dependence_check(), "no loads");

#ifdef ASSERT
// CacheWB nodes are peculiar in a sense that they both are anti-dependent and produce memory.
// Allow them to be treated as a store.
bool is_cache_wb = false;
if (use_mem_state->is_Mach()) {
int ideal_op = use_mem_state->as_Mach()->ideal_Opcode();
is_cache_wb = (ideal_op == Op_CacheWB);
}
assert(!use_mem_state->needs_anti_dependence_check() || is_cache_wb, "no loads");
#endif

// MergeMems do not directly have anti-deps.
// Treat them as internal nodes in a forward tree of memory states,
Expand Down
2 changes: 0 additions & 2 deletions test/hotspot/jtreg/ProblemList.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@

# :hotspot_compiler

applications/ctw/modules/java_base_2.java 8341831 linux-x64

compiler/ciReplay/TestSAServer.java 8029528 generic-all
compiler/compilercontrol/jcmd/ClearDirectivesFileStackTest.java 8225370 generic-all

Expand Down