Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8342979: Start of release updates for JDK 25 #21763

Closed
wants to merge 14 commits into from

Conversation

pavelrappo
Copy link
Member

@pavelrappo pavelrappo commented Oct 29, 2024

Prepare for JDK 25.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change requires CSR request JDK-8343000 to be approved
  • Change must not contain extraneous whitespace
  • Change requires CSR request JDK-8343029 to be approved
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8342999 to be approved

Issues

  • JDK-8342979: Start of release updates for JDK 25 (Bug - P4)
  • JDK-8342982: Add SourceVersion.RELEASE_25 (Sub-task - P4)
  • JDK-8342983: Add source 25 and target 25 to javac (Sub-task - P4)
  • JDK-8343029: Start of release updates for JDK 25 (CSR)
  • JDK-8343000: Add source 25 and target 25 to javac (CSR)
  • JDK-8342999: Add SourceVersion.RELEASE_25 (CSR)

Reviewers

Contributors

  • Joe Darcy <darcy@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21763/head:pull/21763
$ git checkout pull/21763

Update a local copy of the PR:
$ git checkout pull/21763
$ git pull https://git.openjdk.org/jdk.git pull/21763/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21763

View PR using the GUI difftool:
$ git pr show -t 21763

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21763.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 29, 2024

👋 Welcome back prappo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@pavelrappo
Copy link
Member Author

/issue add JDK-8342982
/issue add JDK-8342983

@openjdk
Copy link

openjdk bot commented Oct 29, 2024

@pavelrappo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8342979: Start of release updates for JDK 25
8342982: Add SourceVersion.RELEASE_25
8342983: Add source 25 and target 25 to javac

Co-authored-by: Joe Darcy <darcy@openjdk.org>
Reviewed-by: iris, darcy, erikj, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 29, 2024
@openjdk
Copy link

openjdk bot commented Oct 29, 2024

@pavelrappo
Adding additional issue to issue list: 8342982: Add SourceVersion.RELEASE_25.

@openjdk
Copy link

openjdk bot commented Oct 29, 2024

@pavelrappo
Adding additional issue to issue list: 8342983: Add source 25 and target 25 to javac.

@openjdk
Copy link

openjdk bot commented Oct 29, 2024

@pavelrappo The following labels will be automatically applied to this pull request:

  • build
  • compiler
  • core-libs
  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-runtime hotspot-runtime-dev@openjdk.org build build-dev@openjdk.org core-libs core-libs-dev@openjdk.org compiler compiler-dev@openjdk.org labels Oct 29, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 29, 2024

@pavelrappo
Copy link
Member Author

/contributor add darcy

@openjdk
Copy link

openjdk bot commented Oct 29, 2024

@pavelrappo
Contributor Joe Darcy <darcy@openjdk.org> successfully added.

Copy link
Member

@irisclark irisclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on accepting the baton from Joe!

Confirmed everything as expected.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 29, 2024
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hotspot changes are fine.

Thanks

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Oct 30, 2024
Copy link
Member

@irisclark irisclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional changes (all autogenerated) look good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 30, 2024
Copy link
Member

@jddarcy jddarcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skimmed over the new symbol information and the results look plausible.

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Nov 1, 2024
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 15, 2024
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Nov 25, 2024
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 25, 2024
Pavel Rappo added 2 commits December 2, 2024 22:35
# Conflicts:
#	src/java.compiler/share/classes/javax/lang/model/SourceVersion.java
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Dec 2, 2024
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 3, 2024
@pavelrappo
Copy link
Member Author

/integrate delegate

@openjdk openjdk bot added the delegated label Dec 4, 2024
@openjdk
Copy link

openjdk bot commented Dec 4, 2024

@pavelrappo Integration of this pull request has been delegated and may be completed by any project committer using the /integrate pull request command.

@JesperIRL
Copy link
Member

/integrate

@openjdk
Copy link

openjdk bot commented Dec 5, 2024

Going to push as commit 5cc150c.
Since your change was applied there have been 44 commits pushed to the master branch:

  • 85fedbf: 8344607: Link Time Optimization - basic support for clang
  • 5a0899f: 8345302: Building microbenchmarks require larger Java heap
  • 1ece4f9: 8345514: Should use internal class name when calling ClassLoader.getResourceAsByteArray
  • ef8da28: 8345591: [aarch64] macroAssembler_aarch64.cpp compile fails ceil_log2 not declared
  • 7513b13: 8328944: NMT reports "unknown" memory
  • 691e692: 8345565: Remove remaining SecurityManager motivated APIs from sun.reflect.util
  • 97b8a09: 8345339: JFR: Missing javadoc for RecordingStream::onMetadata
  • 456c71d: 8343699: [aarch64] Bug in MacroAssembler::klass_decode_mode()
  • 308357c: 8345578: New test in JDK-8343622 fails with a promoted build
  • 84240cc: 8344831: [REDO] CDS: Parallel relocation
  • ... and 34 more: https://git.openjdk.org/jdk/compare/79eb77b782bd0c3cecee6c66b86f6f3e17054498...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 5, 2024
@openjdk openjdk bot closed this Dec 5, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review delegated labels Dec 5, 2024
@openjdk
Copy link

openjdk bot commented Dec 5, 2024

@JesperIRL Pushed as commit 5cc150c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org compiler compiler-dev@openjdk.org core-libs core-libs-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

6 participants