Skip to content

8335991: Implement Simple Source Files and Instance Main Methods (Fourth Preview) #21787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

8335991: Implement Simple Source Files and Instance Main Methods (Fourth Preview) #21787

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/java.base/share/classes/jdk/internal/javac/PreviewFeature.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ public enum Feature {
// keeping the constant of a feature that has been integrated or dropped, serves the purpose of muting such warnings.

//---
@JEP(number=477, title="Implicitly Declared Classes and Instance Main Methods", status="Third Preview")
@JEP(number=495, title="Simple Source Files and Instance Main Methods", status="Fourth Preview")
IMPLICIT_CLASSES,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Jan, although it's just an internal enum name, do you think we should rename it to be closer to the JEP's title or is it not worth it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title also shows up in list of preview APIs in the javadoc so changing seems correct.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note the title is adjusted to match the current name of the JEP. So the built javadoc should not be an issue. What Jaikiran is speaking about is the enum constant name, which hopefully(!) does not have a meaning outside of the JDK.

We could change the constant to SIMPLE_SOURCE_FILES_AND_INSTANCE_MAIN_METHODS (to precisely reflect the JEP's name), but it seems like an unnecessary git churn to me. We might also need to keep the existing constant due to bootstrap issues, then remove it when JDK 25 is switched to bootstrap on JDK 24.

I can do that, if really needed, though.

Copy link
Member

@jaikiran jaikiran Nov 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What Jaikiran is speaking about is the enum constant name, which hopefully(!) does not have a meaning outside of the JDK.

I had looked around the rendered javadoc and a few other places and I didn't notice the enum name showing up anywhere publicly. It merely appears to be an internal reference within the code.

@JEP(number=481, title="Scoped Values", status="Third Preview")
SCOPED_VALUES,
Expand Down