-
Notifications
You must be signed in to change notification settings - Fork 6.2k
JDK-8260236: better init AnnotationCollector _contended_group #2231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into |
coleenp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good + trivial. Thank you for fixing these!
|
@MBaesken This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 10 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
@MBaesken Since your change was applied there have been 19 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit fd2641e. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The class AnnotationCollector misses to initialize _contended_group in the constructor, that should be adjusted.
See also the related sonar warning ( 1 uninitialized field at the end of the constructor call):
https://sonarcloud.io/project/issues?id=jdk&open=AXaE0c1g8L9hkQskF8qX&resolved=false&types=BUG
Thanks, Matthias
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/2231/head:pull/2231$ git checkout pull/2231