Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8260236: better init AnnotationCollector _contended_group #2231

Closed
wants to merge 1 commit into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Jan 26, 2021

The class AnnotationCollector misses to initialize _contended_group in the constructor, that should be adjusted.

See also the related sonar warning ( 1 uninitialized field at the end of the constructor call):
https://sonarcloud.io/project/issues?id=jdk&open=AXaE0c1g8L9hkQskF8qX&resolved=false&types=BUG

Thanks, Matthias


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8260236: better init AnnotationCollector _contended_group

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2231/head:pull/2231
$ git checkout pull/2231

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 26, 2021

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 26, 2021
@openjdk
Copy link

openjdk bot commented Jan 26, 2021

@MBaesken The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jan 26, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 26, 2021

Webrevs

Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good + trivial. Thank you for fixing these!

@openjdk
Copy link

openjdk bot commented Jan 26, 2021

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260236: better init AnnotationCollector _contended_group

Reviewed-by: coleenp, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • fd00ed7: 8256298: Shenandoah: Enable concurrent stack processing
  • b07797c: 8260391: Remove StringCoding::err
  • af8a08f: 8260378: [TESTBUG] DcmdMBeanTestCheckJni.java reports false positive
  • 8d2f77f: 8260406: Do not copy pure java source code to gensrc
  • 5e8e0ad: 8242456: PreviewFeature.Feature enum removal of TEXT_BLOCKS
  • e080ce9: 8252545: runtime/ErrorHandling/TestHeapDumpOnOutOfMemoryError.java timed out
  • edd2707: 8260408: Shenandoah: adjust inline hints after JDK-8255019
  • 81a66df: 8259809: Remove PerfEvent class loading locking counters
  • b4ace3e: 8260042: G1 Post-cleanup liveness printing occurs too early
  • 23edb6f: 8236490: Compiler bug relating to @nonnull annotation

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 26, 2021
@MBaesken
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Jan 27, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 27, 2021
@openjdk
Copy link

openjdk bot commented Jan 27, 2021

@MBaesken Since your change was applied there have been 19 commits pushed to the master branch:

  • 1c77046: 8260404: jvm_io.h include missing in a number of files
  • bd2744d: 8260106: Shenandoah: refactor reference updating closures and related code
  • c836da3: 8252412: [macos11] system dynamic libraries removed from filesystem
  • e1411fd: 6606673: Path2D.Double, Path2D.Float and GeneralPath ctors throw exception when initialCapacity is negative
  • 6f2be9c: 8246112: Remove build-time and run-time checks for clock_gettime and CLOCK_MONOTONIC
  • 19b6f61: 8260334: Remove deprecated sv_for_node_id() from Compile
  • 1bebd41: 8260421: Shenandoah: Fix conc_mark_roots timing name and indentations
  • 42cef27: 8260343: Delete obsolete classes in the Windows L&F
  • 9f0a043: 8260286: Manual Test "ws/open/test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java" fails
  • fd00ed7: 8256298: Shenandoah: Enable concurrent stack processing
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/abd9310bff31b5fc1677ab02609641ecc8faf356...master

Your commit was automatically rebased without conflicts.

Pushed as commit fd2641e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@MBaesken MBaesken deleted the JDK-8260236 branch March 4, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants