Skip to content

Conversation

@DamonGuy
Copy link
Contributor

@DamonGuy DamonGuy commented Nov 24, 2024

Backout for #20845. Removes additions to BasicScrollBarUI and removes the test JComboBoxScrollFocusTest. Original PR caused some tests to fail that indicate a memory leak.

Ran clientlibs job in CI, and all relevant tests pass (including the few tests that were failing from the original PR).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8344914: OOME in several tests since JDK-6672644 - JComboBox still scrolling (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22346/head:pull/22346
$ git checkout pull/22346

Update a local copy of the PR:
$ git checkout pull/22346
$ git pull https://git.openjdk.org/jdk.git pull/22346/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22346

View PR using the GUI difftool:
$ git pr show -t 22346

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22346.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 24, 2024

👋 Welcome back dnguyen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 24, 2024

@DamonGuy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344914: OOME in several tests since JDK-6672644 - JComboBox still scrolling

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • a6220fa: 8344303: Remove usage of URLUtil.getConnectPermission from sun.awt.SunToolkit and sun.awt.image.URLImageSource

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 24, 2024
@openjdk
Copy link

openjdk bot commented Nov 24, 2024

@DamonGuy The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Nov 24, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 24, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 24, 2024
@DamonGuy
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 24, 2024

Going to push as commit 6711e13.
Since your change was applied there has been 1 commit pushed to the master branch:

  • a6220fa: 8344303: Remove usage of URLUtil.getConnectPermission from sun.awt.SunToolkit and sun.awt.image.URLImageSource

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 24, 2024
@openjdk openjdk bot closed this Nov 24, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 24, 2024
@openjdk
Copy link

openjdk bot commented Nov 24, 2024

@DamonGuy Pushed as commit 6711e13.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants