Skip to content

8344935: [ubsan]: javaThread.hpp:1241:52: runtime error: load of value 9831830, which is not a valid value for type 'freeze_result' #22361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

8344935: [ubsan]: javaThread.hpp:1241:52: runtime error: load of value 9831830, which is not a valid value for type 'freeze_result' #22361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c70c580
JDK-8344935
MBaesken Nov 25, 2024
f8044bc
set last_freeze at more code locations
MBaesken Nov 26, 2024
a64088d
remove added state, add assert
MBaesken Nov 26, 2024
a0f9b70
add parenthesis, rename variables
MBaesken Nov 27, 2024
6c33887
pchilano comments
MBaesken Dec 3, 2024
568d7af
add missing if check
MBaesken Dec 3, 2024
c0df96a
freeze_preempt remove JFR_ONLY coding
MBaesken Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/hotspot/share/runtime/continuationFreezeThaw.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,9 @@ class Config {
using OopT = std::conditional_t<oops == oop_kind::NARROW, narrowOop, oop>;

static freeze_result freeze(JavaThread* thread, intptr_t* const sp) {
return freeze_internal<SelfT, false>(thread, sp);
freeze_result res = freeze_internal<SelfT, false>(thread, sp);
JFR_ONLY(assert((res == freeze_ok) || (res == thread->last_freeze_fail_result()), "freeze failure not set"));
return res;
}

static freeze_result freeze_preempt(JavaThread* thread, intptr_t* const sp) {
Expand Down Expand Up @@ -1722,6 +1724,9 @@ static inline freeze_result freeze_internal(JavaThread* current, intptr_t* const
log_develop_debug(continuations)("PINNED due to critical section/hold monitor");
verify_continuation(cont.continuation());
freeze_result res = entry->is_pinned() ? freeze_pinned_cs : freeze_pinned_monitor;
if (!preempt) {
JFR_ONLY(current->set_last_freeze_fail_result(res);)
}
log_develop_trace(continuations)("=== end of freeze (fail %d)", res);
// Avoid Thread.yield() loops without safepoint polls.
if (SafepointMechanism::should_process(current) && !preempt) {
Expand Down
6 changes: 5 additions & 1 deletion src/hotspot/share/runtime/javaThread.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,6 +518,10 @@ JavaThread::JavaThread(MemTag mem_tag) :

_SleepEvent(ParkEvent::Allocate(this)),

#if INCLUDE_JFR
_last_freeze_fail_result(freeze_ok),
#endif

_lock_stack(this),
_om_cache(this) {
set_jni_functions(jni_functions());
Expand Down Expand Up @@ -2361,4 +2365,4 @@ void JavaThread::post_vthread_pinned_event(EventVirtualThreadPinned* event, cons
event->commit();
}
}
#endif
#endif