8339313: 32-bit build broken

[tstuefe]

Two fixes to fix the 32-bit build.

See JBS issue and code comment for details.

I ran nNoClassDefFoundErrorTest x64 and x86 fastdebug and release. On fastdebug, the giant string test now gets silently skipped as expected.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8339313: 32-bit build broken (Bug - P4)

Reviewers

• Coleen Phillimore (@coleenp - Reviewer)
• Matthias Baesken (@MBaesken - Reviewer)
• Sonia Zaldana Calles (@SoniaZaldana - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22707/head:pull/22707
$ git checkout pull/22707

Update a local copy of the PR:
$ git checkout pull/22707
$ git pull https://git.openjdk.org/jdk.git pull/22707/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22707

View PR using the GUI difftool:
$ git pr show -t 22707

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22707.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339313: 32-bit build broken

Reviewed-by: coleenp, mbaesken, szaldana

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• f71d515: 8345777: Improve sections for inherited members
• b8bb51e: 8345908: Class links should be properly spaced
• ef6e987: 8346040: Zero interpreter build on Linux Aarch64 is broken
• f7f07b9: 8345804: Update copyright year to 2024 for langtools in files where it was missed
• 1bdb7b4: 8345622: test/langtools/tools/javac/annotations/parameter/ParameterAnnotations.java should set processorpath to work correctly in the agentvm mode
• 0ad6423: 8345944: JEP 492: extending local class in a different static context should not be allowed
• 68aa4d4: 8346063: java/lang/Thread/virtual/Starvation.java missing @requires vm.continuations
• 77e4932: 8344026: Ubsan: prevent potential integer overflow in c1_LIRGenerator_.cpp file
• 3f2556b: 8345984: Remove redundant checkXXX methods from java.management Util class
• ceb4366: 8345955: Deprecate the UseOprofile flag with a view to removing the legacy oprofile support in the VM

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@tstuefe The following labels will be automatically applied to this pull request:

• hotspot-runtime
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (5e9fe26b)

[tstuefe]

@MBaesken?

[coleenp]

Seems reasonable.

[SoniaZaldana]

I am not a Reviewer but this makes sense to me.

[tstuefe]

Thank you all.
/integrate

[openjdk]

Going to push as commit e9ad27f.
Since your change was applied there have been 13 commits pushed to the master branch:

• ff85865: 8346008: Fix recent NULL usage backsliding in Shenandoah
• 11cd639: 8345573: Module dependencies not resolved from run-time image when --limit-module is being used
• 22845a7: 8337995: ZUtils::fill uses std::fill_n
• f71d515: 8345777: Improve sections for inherited members
• b8bb51e: 8345908: Class links should be properly spaced
• ef6e987: 8346040: Zero interpreter build on Linux Aarch64 is broken
• f7f07b9: 8345804: Update copyright year to 2024 for langtools in files where it was missed
• 1bdb7b4: 8345622: test/langtools/tools/javac/annotations/parameter/ParameterAnnotations.java should set processorpath to work correctly in the agentvm mode
• 0ad6423: 8345944: JEP 492: extending local class in a different static context should not be allowed
• 68aa4d4: 8346063: java/lang/Thread/virtual/Starvation.java missing @requires vm.continuations
• ... and 3 more: https://git.openjdk.org/jdk/compare/72c59de615b216c1729de4f4251652488f6f74ef...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tstuefe Pushed as commit e9ad27f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.