Skip to content

Conversation

@albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Dec 13, 2024

This is a clean backport to JDK 24.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8345323: Parallel GC does not handle UseLargePages and UseNUMA gracefully (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22733/head:pull/22733
$ git checkout pull/22733

Update a local copy of the PR:
$ git checkout pull/22733
$ git pull https://git.openjdk.org/jdk.git pull/22733/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22733

View PR using the GUI difftool:
$ git pr show -t 22733

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22733.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 13, 2024

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into jdk24 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 13, 2024

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345323: Parallel GC does not handle UseLargePages and UseNUMA gracefully

Reviewed-by: sjohanss

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the jdk24 branch:

  • 6e8aad1: 8345573: Module dependencies not resolved from run-time image when --limit-module is being used
  • 4d6eccd: 8346159: Disable CDS AOTClassLinking tests for JVMCI due to JDK-8345635

Please see this link for an up-to-date comparison between the source branch of this pull request and the jdk24 branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk24 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport a9a5f7cb0a75b82d613ecd9018e13e5337e90363 8345323: Parallel GC does not handle UseLargePages and UseNUMA gracefully Dec 13, 2024
@openjdk
Copy link

openjdk bot commented Dec 13, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review labels Dec 13, 2024
@openjdk
Copy link

openjdk bot commented Dec 13, 2024

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Dec 13, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 13, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 16, 2024
@albertnetymk
Copy link
Member Author

Thanks for review.

/integrate

@openjdk
Copy link

openjdk bot commented Dec 16, 2024

Going to push as commit 297b21f.
Since your change was applied there have been 3 commits pushed to the jdk24 branch:

  • 67b8251: 8345944: JEP 492: extending local class in a different static context should not be allowed
  • 6e8aad1: 8345573: Module dependencies not resolved from run-time image when --limit-module is being used
  • 4d6eccd: 8346159: Disable CDS AOTClassLinking tests for JVMCI due to JDK-8345635

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 16, 2024
@openjdk openjdk bot closed this Dec 16, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 16, 2024
@openjdk
Copy link

openjdk bot commented Dec 16, 2024

@albertnetymk Pushed as commit 297b21f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the backport-albertnetymk-a9a5f7cb-jdk24 branch December 16, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants