Skip to content

Conversation

@kevinjwalls
Copy link
Contributor

@kevinjwalls kevinjwalls commented Jan 9, 2025

A redundant policy file exists, it is unused and must have been missed during:
8338411: Implement JEP 486: Permanently Disable the Security Manager

Test in test/jdk/javax/management/modelmbean/ModelMBeanInfoSupport still passes after this change.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8347345: Remove redundant test policy file from ModelMBeanInfoSupport directory (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23002/head:pull/23002
$ git checkout pull/23002

Update a local copy of the PR:
$ git checkout pull/23002
$ git pull https://git.openjdk.org/jdk.git pull/23002/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23002

View PR using the GUI difftool:
$ git pr show -t 23002

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23002.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 9, 2025

👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 9, 2025

@kevinjwalls This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347345: Remove redundant test policy file from ModelMBeanInfoSupport directory

Reviewed-by: rriggs, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 59 new commits pushed to the master branch:

  • f6492aa: 8347279: Problemlist TestEvilSyncBug.java#generational
  • 0210a63: 8347379: Problem list failed tests after JDK-8321413
  • a9351df: 8346787: Fix two C2 IR matching tests for RISC-V
  • 89ee1a5: 8343978: Update the default value of CodeEntryAlignment for Ampere-1A and 1B
  • 931914a: 8340631: assert(reserved_rgn->contain_region(base_addr, size)) failed: Reserved CDS region should contain this mapping region
  • 665c39c: 8347375: Extra

    tag in robot specification

  • b335ea9: 8347122: Add missing @serial tags to module java.desktop
  • df28cec: 8345144: Robot does not specify all causes of IllegalThreadStateException
  • 9f3c5f9: 8344907: NullPointerException in Win32ShellFolder2.getSystemIcon when "icon" is null
  • 22f70a7: 8321413: IllegalArgumentException: Code length outside the allowed range while creating a jlink image
  • ... and 49 more: https://git.openjdk.org/jdk/compare/c8a9dd3a027781d006850c028714a62903c487d5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Jan 9, 2025

@kevinjwalls The following labels will be automatically applied to this pull request:

  • jmx
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org jmx jmx-dev@openjdk.org labels Jan 9, 2025
@kevinjwalls kevinjwalls marked this pull request as ready for review January 9, 2025 12:36
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 9, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 9, 2025

Webrevs

Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 9, 2025
@kevinjwalls
Copy link
Contributor Author

Thanks Roger, and Serguei!

@kevinjwalls
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 10, 2025

Going to push as commit 8b07617.
Since your change was applied there have been 59 commits pushed to the master branch:

  • f6492aa: 8347279: Problemlist TestEvilSyncBug.java#generational
  • 0210a63: 8347379: Problem list failed tests after JDK-8321413
  • a9351df: 8346787: Fix two C2 IR matching tests for RISC-V
  • 89ee1a5: 8343978: Update the default value of CodeEntryAlignment for Ampere-1A and 1B
  • 931914a: 8340631: assert(reserved_rgn->contain_region(base_addr, size)) failed: Reserved CDS region should contain this mapping region
  • 665c39c: 8347375: Extra

    tag in robot specification

  • b335ea9: 8347122: Add missing @serial tags to module java.desktop
  • df28cec: 8345144: Robot does not specify all causes of IllegalThreadStateException
  • 9f3c5f9: 8344907: NullPointerException in Win32ShellFolder2.getSystemIcon when "icon" is null
  • 22f70a7: 8321413: IllegalArgumentException: Code length outside the allowed range while creating a jlink image
  • ... and 49 more: https://git.openjdk.org/jdk/compare/c8a9dd3a027781d006850c028714a62903c487d5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 10, 2025
@openjdk openjdk bot closed this Jan 10, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 10, 2025
@openjdk
Copy link

openjdk bot commented Jan 10, 2025

@kevinjwalls Pushed as commit 8b07617.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated jmx jmx-dev@openjdk.org serviceability serviceability-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

3 participants