Skip to content

Conversation

@robehn
Copy link
Contributor

@robehn robehn commented Jan 9, 2025

Hi please consider this minor improvement.

Sanity tested.

Thanks, Robbin


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8347366: RISC-V: Add extension asserts for CMO instructions (Enhancement - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23015/head:pull/23015
$ git checkout pull/23015

Update a local copy of the PR:
$ git checkout pull/23015
$ git pull https://git.openjdk.org/jdk.git pull/23015/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23015

View PR using the GUI difftool:
$ git pr show -t 23015

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23015.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 9, 2025

👋 Welcome back rehn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 9, 2025

@robehn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347366: RISC-V: Add extension asserts for CMO instructions

Reviewed-by: fyang, mli

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 136 new commits pushed to the master branch:

  • 2c41f5a: 8347959: ThreadDumper leaks memory
  • 15e06b6: 8345618: javax/swing/text/Caret/8163124/CaretFloatingPointAPITest.java leaves Caret is not complete
  • 3ab521e: 8347924: Replace SIZE_FORMAT in memory and metaspace
  • 8460072: 8342881: RISC-V: secondary_super_cache does not scale well: C1 and interpreter
  • f5573f5: 8330851: C2: More efficient TypeFunc creation
  • a3eef6c: 8346875: Test jdk/jdk/jfr/event/os/TestCPULoad.java fails on macOS
  • 398a580: 8347911: Limit the length of inflated text chunks
  • aa21de5: 8347481: C2: Remove the control input of some nodes
  • 1f365cc: 8346433: Cannot use DllMain in hotspot for static builds
  • 0330ca4: 8347617: Shenandoah: Use consistent name for update references phase
  • ... and 126 more: https://git.openjdk.org/jdk/compare/3bfa9521d5b7e702e842fe1297dbb2ed643f0b0a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 9, 2025
@openjdk
Copy link

openjdk bot commented Jan 9, 2025

@robehn The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jan 9, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 9, 2025

Webrevs

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! I only see two typos in code comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 10, 2025
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Jan 10, 2025
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 10, 2025
Copy link

@Hamlin-Li Hamlin-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@robehn
Copy link
Contributor Author

robehn commented Jan 18, 2025

Thank you @Hamlin-Li !

@robehn
Copy link
Contributor Author

robehn commented Jan 18, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jan 18, 2025

Going to push as commit ca8ba5c.
Since your change was applied there have been 143 commits pushed to the master branch:

  • 0ff6700: 8347987: Bad ifdef in 8330851
  • e1cf351: 8348013: [doc] fix typo in java.md caused by JDK-8347763
  • 6ef860c: 8332857: Test vmTestbase/nsk/jvmti/GetThreadCpuTime/thrcputime002/TestDescription.java failed
  • 17e3df6: 8347763: [doc] Add documentation of module options for JEP 483
  • 6cc1c0a: 8347422: Crash during safepoint handler execution with -XX:+UseAPX
  • baca7da: 8347733: Replace SIZE_FORMAT in runtime code
  • 2ca1b4d: 8347840: Fix testlibrary compilation warnings
  • 2c41f5a: 8347959: ThreadDumper leaks memory
  • 15e06b6: 8345618: javax/swing/text/Caret/8163124/CaretFloatingPointAPITest.java leaves Caret is not complete
  • 3ab521e: 8347924: Replace SIZE_FORMAT in memory and metaspace
  • ... and 133 more: https://git.openjdk.org/jdk/compare/3bfa9521d5b7e702e842fe1297dbb2ed643f0b0a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 18, 2025
@openjdk openjdk bot closed this Jan 18, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 18, 2025
@openjdk
Copy link

openjdk bot commented Jan 18, 2025

@robehn Pushed as commit ca8ba5c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@robehn robehn deleted the 8347366-cmo branch January 28, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants