-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8348205: Improve cutover time selection when building available currencies set #23309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8348205: Improve cutover time selection when building available currencies set #23309
Conversation
|
👋 Welcome back jlu! A progress list of the required criteria for merging this PR into |
|
@justin-curtis-lu This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 66 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@justin-curtis-lu The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
naotoj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Please update the copyright year to 2025
| public static Set<Currency> getAvailableCurrencies() { | ||
| synchronized(Currency.class) { | ||
| if (available == null) { | ||
| // reuse same time for all special case cut-over date checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment is correct, but it might not be necessary, as it would not be significant unless one knows the background
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment removed and year bumped.
RogerRiggs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Thanks for reviewing. |
|
Going to push as commit a224f12.
Your commit was automatically rebased without conflicts. |
|
@justin-curtis-lu Pushed as commit a224f12. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this PR which improves the time measurement for cut-over time comparisons when building the available set of currencies in java.util.Currency. Currently, a new time was measured for each special case currency. This PR updates the behavior to use the same time for all such cases
Progress
Issues
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23309/head:pull/23309$ git checkout pull/23309Update a local copy of the PR:
$ git checkout pull/23309$ git pull https://git.openjdk.org/jdk.git pull/23309/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23309View PR using the GUI difftool:
$ git pr show -t 23309Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23309.diff
Using Webrev
Link to Webrev Comment