Skip to content

Conversation

@justin-curtis-lu
Copy link
Member

@justin-curtis-lu justin-curtis-lu commented Jan 24, 2025

Please review this PR which improves the time measurement for cut-over time comparisons when building the available set of currencies in java.util.Currency. Currently, a new time was measured for each special case currency. This PR updates the behavior to use the same time for all such cases


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8348205: Improve cutover time selection when building available currencies set (Bug - P4)
  • JDK-8348216: Improve cutover time selection when building available currencies set (CSR) (Withdrawn)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23309/head:pull/23309
$ git checkout pull/23309

Update a local copy of the PR:
$ git checkout pull/23309
$ git pull https://git.openjdk.org/jdk.git pull/23309/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23309

View PR using the GUI difftool:
$ git pr show -t 23309

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23309.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 24, 2025

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 24, 2025

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8348205: Improve cutover time selection when building available currencies set

Reviewed-by: naoto, rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 66 new commits pushed to the master branch:

  • 8cc1304: 8287788: Implement a better allocator for downcalls
  • 039e73f: 8346736: Java Security Standard Algorithm Names spec should include key algorithm names
  • aba60a9: 8189441: Define algorithm names for keys derived from KeyAgreement
  • 03106eb: 8344119: CUPSPrinter does not respect PostScript printer definition specification in case of reading ImageableArea values from PPD files
  • ad01dfb: 8346920: Serial: Support allocation in old generation when heap is almost full
  • 1d8ccb8: 8342465: Improve API documentation for java.lang.classfile
  • 7d6055a: 8348429: Update cross-compilation devkits to Fedora 41/gcc 13.2
  • f1e0797: 8348586: Optionally silence make warnings about non-control variables
  • ffeb9b5: 8342807: Update links in java.base to use https://
  • afcc2b0: 8348562: ZGC: segmentation fault due to missing node type check in barrier elision analysis
  • ... and 56 more: https://git.openjdk.org/jdk/compare/b720517cb33c2119ec6ed85504bce321de748228...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 24, 2025
@openjdk
Copy link

openjdk bot commented Jan 24, 2025

@justin-curtis-lu The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Jan 24, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 25, 2025

Webrevs

Copy link
Member

@naotoj naotoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please update the copyright year to 2025

public static Set<Currency> getAvailableCurrencies() {
synchronized(Currency.class) {
if (available == null) {
// reuse same time for all special case cut-over date checks
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is correct, but it might not be necessary, as it would not be significant unless one knows the background

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment removed and year bumped.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 27, 2025
Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@justin-curtis-lu
Copy link
Member Author

Thanks for reviewing.
/integrate

@openjdk
Copy link

openjdk bot commented Jan 28, 2025

Going to push as commit a224f12.
Since your change was applied there have been 79 commits pushed to the master branch:

  • 8103256: 8348348: Remove unnecessary #ifdef STATIC_BUILD around DEF_STATIC_JNI_OnLoad from zip_util.c
  • fb066ca: 8347272: [ubsan] JvmLauncher.cpp:262:52: runtime error: applying non-zero offset 40 to null pointer
  • 5fec999: 8339668: Parallel: Adopt PartialArrayState to consolidate marking stack in Full GC
  • 2bef5b4: 8348323: Corrupted timezone string in JVM crash log
  • 3a8680e: 8347058: When automatically translating the page to pt-br, all CSS styling disappears
  • a4942a2: 8348286: [AIX] clang 17 introduces new warning Wtentative-Definitions which produces Build errors
  • 558255a: 8328919: Add BodyHandlers / BodySubscribers methods to handle excessive server input
  • 1f74caa: 8348401: [IR Framework] PrintTimes should not require verbose
  • f71541c: 8344976: Remove the jmx.invoke.getters compatibility property
  • 2537a05: 8348384: RISC-V: Disable auto-enable Vector on buggy kernels
  • ... and 69 more: https://git.openjdk.org/jdk/compare/b720517cb33c2119ec6ed85504bce321de748228...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 28, 2025
@openjdk openjdk bot closed this Jan 28, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 28, 2025
@openjdk
Copy link

openjdk bot commented Jan 28, 2025

@justin-curtis-lu Pushed as commit a224f12.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants