8349040: Test compiler/inlining/LateInlinePrinting.java fails after JDK-8319850

[sendaoYan]

Hi all,

This PR fix the test bug which report "VM option 'AlwaysIncrementalInline' is develop and is available only in debug version of VM". Change has been verified locally, test-fix only, no risk.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8349040: Test compiler/inlining/LateInlinePrinting.java fails after JDK-8319850 (Bug - P4)

Reviewers

• Matthias Baesken (@MBaesken - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23364/head:pull/23364
$ git checkout pull/23364

Update a local copy of the PR:
$ git checkout pull/23364
$ git pull https://git.openjdk.org/jdk.git pull/23364/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23364

View PR using the GUI difftool:
$ git pr show -t 23364

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23364.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349040: Test compiler/inlining/LateInlinePrinting.java fails after JDK-8319850

Reviewed-by: mbaesken, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

• 5d5b294: 8349070: Fix riscv and ppc build errors caused by JDK-8343767
• 3f8a875: 8348880: Replace ConcurrentMap with AtomicReferenceArray for ZoneOffset.QUARTER_CACHE
• fac63d4: 8348668: Prevent first resource cleanup in confined arena from escaping
• 2efb6aa: 8345314: Add a red–black tree as a utility data structure
• a937f6d: 8343767: Enumerate StubGen blobs, stubs and entries and generate code from declarations
• 1858dc1: 8336382: Fix error reporting in loading AWT
• 22069ff: 8348975: Broken links in the JDK 24 JavaDoc API documentation, build 33

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@sendaoYan The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (480df573)
• 00: Full (75a956cd)

[MBaesken]

Hi, the unchanged test works with our debug builds so I am not sure if you need the added UnlockDiagnosticVMOptions switch; at least we did not need it in the nightly tests .
Otherwise looks good to fix the issue in debug .

[sendaoYan]

Hi, the unchanged test works with our debug builds so I am not sure if you need the added UnlockDiagnosticVMOptions switch; at least we did not need it in the nightly tests . Otherwise looks good to fix the issue in debug .

I think the VM option '-XX:+UnlockDiagnosticVMOptions' is unnecessary after add @requires vm.debug == true. Thanks for the suggest.

[MBaesken]

Hi, the unchanged test works with our debug builds so I am not sure if you need the added UnlockDiagnosticVMOptions switch; at least we did not need it in the nightly tests . Otherwise looks good to fix the issue in debug .

I think the VM option '-XX:+UnlockDiagnosticVMOptions' is unnecessary after add @requires vm.debug == true. Thanks for the suggest.

Yes in the debug-build binaries '-XX:+PrintInlining' works without '-XX:+UnlockDiagnosticVMOptions' . If you plan to make the test work in opt too you need this additional flag. If you stay debug-only it works without it .

[sendaoYan]

Yes in the debug-build binaries '-XX:+PrintInlining' works without '-XX:+UnlockDiagnosticVMOptions' . If you plan to make the test work in opt too you need this additional flag. If you stay debug-only it works without it .

VM option 'AlwaysIncrementalInline' is available only in debug build. So I stay debug-only, and remove '-XX:+UnlockDiagnosticVMOptions'.

[TobiHartmann]

Looks good and trivial.

[sendaoYan]

GHA report several failures:

1. windows-aarch64 / build (release) and windows-aarch64 / build (debug) job fails 'Unexpected HTTP response: 504' at 'Get MSYS2' stage, seems like environmental issue or infrastructure issue, it's unreleated to this PR.
2. windows-x64 / build (debug) and windows-x64 / build (release) job fails 'Unexpected HTTP response: 504' at 'Get MSYS2' stage, seems like environmental issue or infrastructure issue, it's unreleated to this PR.

[sendaoYan]

To make less CI noisy, I will integrate this PR now, ignore the 24 hours review time limit.

/integrate

[openjdk]

Going to push as commit 2df9d5b.
Since your change was applied there have been 18 commits pushed to the master branch:

• 03f5c33: 8349122: -XX:+AOTClassLinking is not compatible with jdwp
• 0d30b86: 8344581: [TESTBUG] java/awt/Robot/ScreenCaptureRobotTest.java failing on macOS
• cdc84ac: 8348890: Fix docs for -XX:AOT* options in java man page
• 8986cb2: 8331873: Improve/expand info in New API In on Help page
• d589a82: 8349101: Problemlist HeadlessMalfunctionTest.java
• f05c53c: 8347949: Currency method to stream available Currencies
• cc775b1: 8348648: Unnecessary Hashtable usage in javax.swing.text.html.CSS.LengthUnit
• 06ebb17: 8349002: GenShen: Deadlock during shutdown
• 1ac2d6e: 8349009: JVM fails to start when AOTClassLinking is used with unverifiable old classes
• 0cae888: 8349003: NativeCallStack::print_on() output is unreadable
• ... and 8 more: https://git.openjdk.org/jdk/compare/f81772a49ebfa197bac7bf05cf7d468d819f742a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sendaoYan Pushed as commit 2df9d5b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.