8349058: 'internal proprietary API' warnings make javac warnings unusable

[cushon]

This change is a partial backout of JDK-8332744. The logic was reverted, but the test was preserved and updated to reflect the updated behaviour, and some cleanups to benchmark code were kept.

This restores the ability to use -XDignore.symbol.file as an ad-hoc suppression mechanism for sunapi diagnostics, see discussion in JDK-8349058.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8349058: 'internal proprietary API' warnings make javac warnings unusable (Bug - P3)

Reviewers

• Vicente Romero (@vicente-romero-oracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23448/head:pull/23448
$ git checkout pull/23448

Update a local copy of the PR:
$ git checkout pull/23448
$ git pull https://git.openjdk.org/jdk.git pull/23448/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23448

View PR using the GUI difftool:
$ git pr show -t 23448

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23448.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cushon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@cushon This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349058: 'internal proprietary API' warnings make javac warnings unusable

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

• 5ec1aae: 8347842: ThreadPoolExecutor specification discusses RuntimePermission
• 3fbae32: 8349465: [UBSAN] test_os_reserve_between.cpp reported applying non-zero offset to null pointer
• e0487c7: 8346777: Add missing const declarations and rename variables
• 2b82e2d: 8347958: Minor compiler cleanups relating to MandatoryWarningHandler
• 2093bb7: 8346434: Add test for non-automatic service binding
• dd8720e: 8348520: [s390x] Problemlist TestVectorReinterpret.java
• 4618993: 8349537: Bad copyright in TestArrayStructs.java
• acb46dd: 8345155: Add /native to native test in FFM
• d85f651: 8349428: RISC-V: "bad alignment" with -XX:-AvoidUnalignedAccesses after JDK-8347489
• 7e30791: 8349102: Test compiler/arguments/TestCodeEntryAlignment.java failed: assert(allocates2(pc)) failed: not in CodeBuffer memory
• ... and 22 more: https://git.openjdk.org/jdk/compare/bad39b6d8892ba9b86bc81bf01108a1df617defb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@cushon The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (9bf37fc6)
• 00: Full (48388688)

[vicente-romero-oracle]

lgtm, thanks!

[cushon]

/integrate

[openjdk]

Going to push as commit 1ab1c1d.
Since your change was applied there have been 34 commits pushed to the master branch:

• eb84702: 8349513: Remove unused BUILD_JDK_JTREG_LIBRARIES_JDK_LIBS_libTracePinnedThreads
• f12d2de: 8345212: Since checker should better handle non numeric values
• 5ec1aae: 8347842: ThreadPoolExecutor specification discusses RuntimePermission
• 3fbae32: 8349465: [UBSAN] test_os_reserve_between.cpp reported applying non-zero offset to null pointer
• e0487c7: 8346777: Add missing const declarations and rename variables
• 2b82e2d: 8347958: Minor compiler cleanups relating to MandatoryWarningHandler
• 2093bb7: 8346434: Add test for non-automatic service binding
• dd8720e: 8348520: [s390x] Problemlist TestVectorReinterpret.java
• 4618993: 8349537: Bad copyright in TestArrayStructs.java
• acb46dd: 8345155: Add /native to native test in FFM
• ... and 24 more: https://git.openjdk.org/jdk/compare/bad39b6d8892ba9b86bc81bf01108a1df617defb...master

Your commit was automatically rebased without conflicts.

[openjdk]

@cushon Pushed as commit 1ab1c1d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.