-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8345155: Add /native to native test in FFM #23458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
|
@sendaoYan This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
@sendaoYan The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
mcimadamore
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work. We also have a TestMatrix which is a manual test - but that one does seem to already have /native
minborg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this issue!
|
Thanks all for the reviews. /integrate |
|
Going to push as commit acb46dd.
Your commit was automatically rebased without conflicts. |
|
@sendaoYan Pushed as commit acb46dd. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This PR add
/nativekeyword in the test header for FFM tests. The/nativekeyword will make run the related tests by jtreg standalone more friendly.I runed all the FFM tests without
-nativepathargument and find the fail tests. This will find all the FFM tests which missing '/native' flag.Change has been verified locally, test-fix, no risk.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23458/head:pull/23458$ git checkout pull/23458Update a local copy of the PR:
$ git checkout pull/23458$ git pull https://git.openjdk.org/jdk.git pull/23458/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23458View PR using the GUI difftool:
$ git pr show -t 23458Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23458.diff
Using Webrev
Link to Webrev Comment