Skip to content

Conversation

@sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Feb 5, 2025

Hi all,

This PR add /native keyword in the test header for FFM tests. The /native keyword will make run the related tests by jtreg standalone more friendly.

I runed all the FFM tests without -nativepath argument and find the fail tests. This will find all the FFM tests which missing '/native' flag.

Change has been verified locally, test-fix, no risk.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8345155: Add /native to native test in FFM (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23458/head:pull/23458
$ git checkout pull/23458

Update a local copy of the PR:
$ git checkout pull/23458
$ git pull https://git.openjdk.org/jdk.git pull/23458/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23458

View PR using the GUI difftool:
$ git pr show -t 23458

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23458.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 5, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 5, 2025

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345155: Add /native to native test in FFM

Reviewed-by: mcimadamore, pminborg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 2ff8440: 8349344: Clarify documentation of Arena.ofConfined
  • 19399d2: 8348572: C2 compilation asserts due to unexpected irreducible loop
  • 6146588: 8348190: Framework for tracing makefile inclusion and parsing
  • 66a3898: 8348659: AArch64: IR rule failure with compiler/loopopts/superword/TestSplitPacks.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 5, 2025
@openjdk
Copy link

openjdk bot commented Feb 5, 2025

@sendaoYan The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Feb 5, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 5, 2025

Webrevs

Copy link
Contributor

@mcimadamore mcimadamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. We also have a TestMatrix which is a manual test - but that one does seem to already have /native

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 5, 2025
Copy link
Contributor

@minborg minborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this issue!

@sendaoYan
Copy link
Member Author

Thanks all for the reviews.

/integrate

@openjdk
Copy link

openjdk bot commented Feb 6, 2025

Going to push as commit acb46dd.
Since your change was applied there have been 19 commits pushed to the master branch:

  • d85f651: 8349428: RISC-V: "bad alignment" with -XX:-AvoidUnalignedAccesses after JDK-8347489
  • 7e30791: 8349102: Test compiler/arguments/TestCodeEntryAlignment.java failed: assert(allocates2(pc)) failed: not in CodeBuffer memory
  • 3eb57f6: 8349140: Size optimization (opt-size) build fails after recent PCH changes
  • 3cf04de: 8349132: javac Analyzers should handle non-deferrable errors
  • 30f7162: 8349417: Fix NULL usage from JDK-8346433
  • 64bd8d2: 8349511: [BACKOUT] Framework for tracing makefile inclusion and parsing
  • 5e1cc08: 8349504: Support platform-specific JUnit tests in jpackage
  • 89e5e7a: 8349155: The "log" parameter to Lint.logIfEnabled() is not needed
  • aad6664: 8333569: jpackage tests must run app launchers with retries on Linux only
  • b499c82: 8349383: (fs) FileTreeWalker.next() superfluous null check of visit() return value
  • ... and 9 more: https://git.openjdk.org/jdk/compare/40603a5bf039eef03c157bfc49ac8ea2229a94de...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 6, 2025
@openjdk openjdk bot closed this Feb 6, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 6, 2025
@openjdk
Copy link

openjdk bot commented Feb 6, 2025

@sendaoYan Pushed as commit acb46dd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan sendaoYan deleted the jbs8345155 branch February 11, 2025 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants