-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8349504: Support platform-specific JUnit tests in jpackage #23479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8349504: Support platform-specific JUnit tests in jpackage #23479
Conversation
…ration for adding platform-specific junit tests
|
👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into |
|
@alexeysemenyukoracle This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
@alexeysemenyukoracle The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
@sashamatveev PTAL |
sashamatveev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
|
/integrate |
|
@alexeysemenyukoracle Pushed as commit 5e1cc08. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Move junit tests to
sharesubfolder.Adjust
TEST.propertiesto grant full access to classes in alljdk.jpackagemodule packages. Otherwise, jtreg picks access config from the parentTEST.properties, which allows full access tojdk.jpackage.internalpackage only.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23479/head:pull/23479$ git checkout pull/23479Update a local copy of the PR:
$ git checkout pull/23479$ git pull https://git.openjdk.org/jdk.git pull/23479/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23479View PR using the GUI difftool:
$ git pr show -t 23479Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23479.diff
Using Webrev
Link to Webrev Comment