8349532: Refactor ./util/Pem/encoding.sh to run in java

[myankelev]

• ./util/Pem/encoding.sh is now a java test
• also added the validations for the test results, not only an error check

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8349532: Refactor ./util/Pem/encoding.sh to run in java (Sub-task - P4)

Reviewers

• Weijun Wang (@wangweij - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23492/head:pull/23492
$ git checkout pull/23492

Update a local copy of the PR:
$ git checkout pull/23492
$ git pull https://git.openjdk.org/jdk.git pull/23492/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23492

View PR using the GUI difftool:
$ git pr show -t 23492

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23492.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back myankelev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@myankelev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349532: Refactor ./util/Pem/encoding.sh to run in java

Reviewed-by: weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 76 new commits pushed to the master branch:

• 86cec4e: 8343782: G1: Use one G1CardSet instance for multiple old gen regions
• 006ed5c: 8349375: Cleanup AIX special file build settings
• 3989a19: 8344925: translet-name ignored when package-name is also set
• 1eb54e4: 8346049: jdk/test/lib/security/timestamp/TsaServer.java warnings
• a0c7f66: 8349508: runtime/cds/appcds/TestParallelGCWithCDS.java should not check for specific output
• 1079147: 8348570: CTW: Expose the code hidden by uncommon traps
• 1a74ee6: 8349092: File.getFreeSpace violates specification if quotas are in effect (win)
• 0181030: 8349006: File.getCanonicalPath should remove "(on UNIX platforms)" from its specification
• ed8945a: 8347377: Add validation checks for ICC_Profile header fields
• 1ab1c1d: 8349058: 'internal proprietary API' warnings make javac warnings unusable
• ... and 66 more: https://git.openjdk.org/jdk/compare/8f7e6e2dbc0a3ccf56242bf071e57bfd671de951...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@wangweij) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@myankelev The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (9989db6c)
• 02: Full - Incremental (0d142e54)
• 01: Full - Incremental (88c4b729)
• 00: Full (2f524826)

[fguallini]

LGTM

[wangweij]

Thanks. The updated test runs fine.

Out of curiosity, I append .reportDiagnosticSummary() to the last line in main and see the output string contains garbaged characters. It looks like although the original fix made it possible to read in a PEM certificate with such a default encoding, it had not fixed the toString part of the certificate. Can you try to fix it as well? It could be another bug since this one is only about the test.

[myankelev]

Thanks. The updated test runs fine.

Out of curiosity, I append .reportDiagnosticSummary() to the last line in main and see the output string contains garbaged characters. It looks like although the original fix made it possible to read in a PEM certificate with such a default encoding, it had not fixed the toString part of the certificate. Can you try to fix it as well? It could be another bug since this one is only about the test.

created a new product bug for this JDK-8349664

[myankelev]

/integrate

[openjdk]

@myankelev
Your change (at version 9989db6) is now ready to be sponsored by a Committer.

[wangweij]

/sponsor

[openjdk]

Going to push as commit 7cd5cb2.
Since your change was applied there have been 76 commits pushed to the master branch:

• 86cec4e: 8343782: G1: Use one G1CardSet instance for multiple old gen regions
• 006ed5c: 8349375: Cleanup AIX special file build settings
• 3989a19: 8344925: translet-name ignored when package-name is also set
• 1eb54e4: 8346049: jdk/test/lib/security/timestamp/TsaServer.java warnings
• a0c7f66: 8349508: runtime/cds/appcds/TestParallelGCWithCDS.java should not check for specific output
• 1079147: 8348570: CTW: Expose the code hidden by uncommon traps
• 1a74ee6: 8349092: File.getFreeSpace violates specification if quotas are in effect (win)
• 0181030: 8349006: File.getCanonicalPath should remove "(on UNIX platforms)" from its specification
• ed8945a: 8347377: Add validation checks for ICC_Profile header fields
• 1ab1c1d: 8349058: 'internal proprietary API' warnings make javac warnings unusable
• ... and 66 more: https://git.openjdk.org/jdk/compare/8f7e6e2dbc0a3ccf56242bf071e57bfd671de951...master

Your commit was automatically rebased without conflicts.

[openjdk]

@wangweij @myankelev Pushed as commit 7cd5cb2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.