Skip to content

Conversation

@plummercj
Copy link
Contributor

@plummercj plummercj commented Feb 8, 2025

Now that we have retired OSX 11 and earlier, JDK-8267433 does not seem to reproduce anymore. I ran the SA core file tests about 2000 times and only saw 1 failure, and it was not related to JDK-8267433. I think this is acceptable and we should make SA core file tests on macosx-x64 part of our CI testing again and see how they do.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8349684: Remove SA core file tests from problem list for macosx-x64 (Sub-task - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23529/head:pull/23529
$ git checkout pull/23529

Update a local copy of the PR:
$ git checkout pull/23529
$ git pull https://git.openjdk.org/jdk.git pull/23529/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23529

View PR using the GUI difftool:
$ git pr show -t 23529

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23529.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 8, 2025

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 8, 2025

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349684: Remove SA core file tests from problem list for macosx-x64

Reviewed-by: kevinw, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 164 new commits pushed to the master branch:

  • 8c09d40: 8348268: Test gc/shenandoah/TestResizeTLAB.java#compact: fatal error: Before Updating References: Thread C2 CompilerThread1: expected gc-state 9, actual 21
  • e7157d1: 8150442: Enforce Supported Platforms in Packager for MSI bundles
  • 6428165: 8349254: Disable "best-fit" mapping on Windows environment variables
  • 32dc41c: 8349624: Validation for slot missing in CodeBuilder local variable instructions
  • a1bcda2: 8349579: jsvml.dll incorrect RDATA SEGMENT specification
  • ee079fd: 8349820: Temporarily increase MemLimit for tests until JDK-8349772 and JDK-8337821 are fixed
  • 545d19f: 8349771: Replace usages of -mx and -ms in some monitor tests
  • 5ee44c1: 8349662: SSLTube SSLSubscriptionWrapper has potential races when switching subscriptions
  • 964dd18: 8349515: [REDO] Framework for tracing makefile inclusion and parsing
  • 8e85829: 8349213: G1: Clearing bitmaps during collection set merging not claimed by region
  • ... and 154 more: https://git.openjdk.org/jdk/compare/81032560f797dc18bd6a4a75b44c26925aabac5b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8349684 8349684: Remove SA core file tests from problem list for macosx-x64 Feb 8, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 8, 2025
@openjdk
Copy link

openjdk bot commented Feb 8, 2025

@plummercj To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@plummercj
Copy link
Contributor Author

/label serviceability

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Feb 8, 2025
@openjdk
Copy link

openjdk bot commented Feb 8, 2025

@plummercj
The serviceability label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Feb 8, 2025

Webrevs

Copy link
Contributor

@kevinjwalls kevinjwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 11, 2025
Copy link
Contributor

@sspitsyn sspitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@plummercj
Copy link
Contributor Author

Thank you for the reviews Kevin and Serguei!

/integrate

@openjdk
Copy link

openjdk bot commented Feb 12, 2025

Going to push as commit 74e458b.
Since your change was applied there have been 178 commits pushed to the master branch:

  • ba28119: 8348427: DeferredLintHandler API should use JCTree instead of DiagnosticPosition
  • c5ac3c4: 8249831: Test sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java is marked with @ignore
  • 336d0d8: 8349926: [BACKOUT] Support static JDK in libfontmanager/freetypeScaler.c
  • 4b463ee: 8342103: C2 compiler support for Float16 type and associated scalar operations
  • 332d87c: 8349859: Support static JDK in libfontmanager/freetypeScaler.c
  • 73e1780: 8349836: G1: Improve group prediction log message
  • ed17c55: 8349145: Make Class.getProtectionDomain() non-native
  • e700460: 8349813: Test behavior of limiting() on RS operators throwing exceptions
  • 08f4c1c: 8349781: make test TEST=gtest fails on WSL
  • bb41df4: 8349723: Problemlist jdp tests for macosx-x64
  • ... and 168 more: https://git.openjdk.org/jdk/compare/81032560f797dc18bd6a4a75b44c26925aabac5b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 12, 2025
@openjdk openjdk bot closed this Feb 12, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 12, 2025
@openjdk
Copy link

openjdk bot commented Feb 12, 2025

@plummercj Pushed as commit 74e458b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

3 participants